fix(janitor): Update min auth level on janitor RR sync

[MagnusSandgren]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request updates the SQL merge statement within the Merge method of a repository. A new line was added to update the MinimumAuthenticationLevel field along with the existing update of UpdatedAt when a match occurs. Additionally, a comment specifying the SQL language was introduced above the SQL string declaration. No changes were made to the declarations of exported or public entities.

Changes

File	Change Summary
src/Digdir.Domain.Dialogporten.Infra.../Repositories/ResourcePolicyInformationRepository.cs	Modified the SQL merge statement in the Merge method to update both UpdatedAt and the new MinimumAuthenticationLevel field. Added a comment noting the SQL language above the SQL string declaration.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Digdir.Domain.Dialogporten.Infrastructure/Persistence/Repositories/ResourcePolicyInformationRepository.cs (1)

39-39: Consider aligning parameter name for consistency

There's a naming inconsistency between the SQL parameter name minimumSecurityLevel and the C# property name MinimumAuthenticationLevel. While functionally correct, it would improve code clarity to use consistent naming.

- 	    as s(id, resource, minimumSecurityLevel, createdAt, updatedAt)
+ 	    as s(id, resource, minimumAuthenticationLevel, createdAt, updatedAt)

And update the references in lines 47 and 50 accordingly.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f2d557 and 85fa850.

📒 Files selected for processing (1)

• src/Digdir.Domain.Dialogporten.Infrastructure/Persistence/Repositories/ResourcePolicyInformationRepository.cs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build / build-and-test

🔇 Additional comments (2)

src/Digdir.Domain.Dialogporten.Infrastructure/Persistence/Repositories/ResourcePolicyInformationRepository.cs (2)

33-33: Good practice adding SQL language annotation

This SQL language comment helps IDEs provide proper syntax highlighting and can enable better code analysis tools to work with your embedded SQL.

---

45-47: Correctly implemented the minimum authentication level update

The change now properly updates both the UpdatedAt and MinimumAuthenticationLevel fields when a record already exists, which aligns with the PR objective to update the minimum authentication level on janitor sync.

[oskogstad]

Testa å sette alle lokalt til 0, restarta APIet, alle ble oppdatert 👌🏼