Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Manual editing of the fields in Table columns config (subform) #13980

Closed
Annikenkbrathen opened this issue Nov 5, 2024 · 12 comments · Fixed by #14318
Closed

UX: Manual editing of the fields in Table columns config (subform) #13980

Annikenkbrathen opened this issue Nov 5, 2024 · 12 comments · Fixed by #14318
Labels
kind/feature-request Feature request that will be considered. team/studio-domain2 ux UX help needed

Comments

@Annikenkbrathen
Copy link

Description

As a user, I want to be able to override the texts in the table according to my needs. I still want to retrieve the correct component that should be linked to the table first, but I would like the option to replace the existing text with a custom one.

We chose in the analysis that users should be allowed to select a component from the linked subform to copy settings from, while also enabling manual editing of the fields. This provides flexibility for users to either use existing settings or make custom adjustments as needed.

In this issue, Design need to figure out how this config should look like.

Additional Information

No response

@Annikenkbrathen
Copy link
Author

Design suggestion in Figma!

The title changes from showing that we are retrieving the Ledetekst, to calling it "Kolonnenavn" and suggesting the Ledetekst text as the default Kolonnenavn. This allows the user to decide whether they want to change the text. We don't modify the text in the component, but override the text.

The idea is that by calling the field "Kolonnenavn," the user understands that we are referring to the display name in the table and won't be confused about whether they are changing a display name or the actual text key of the component.

Additionally, I have suggested showing which "query" is displayed in the cell, and calling it "Cell Content." This cannot be edited at the moment, but is shown for the user's information and context.

Image

@Annikenkbrathen Annikenkbrathen moved this from 👷 In Progress to 🔎 Review in Team Studio Dec 5, 2024
@lassopicasso
Copy link
Contributor

This looks great! 🙂 Nice touch with the default (label) name and the use of toggleable field.
@Annikenkbrathen , do you want more people to take a look at it before it is good to go and start building?

@Annikenkbrathen
Copy link
Author

Great, thanks!
Not for me. Perhaps @Ildest would like to look at the content(?) She hasn't worked on the label names with me yet. But you can probably start building a bit until she's back.

@lassopicasso lassopicasso self-assigned this Dec 9, 2024
@lassopicasso lassopicasso moved this from 🔎 Review to 👷 In Progress in Team Studio Dec 9, 2024
@Ildest
Copy link
Contributor

Ildest commented Dec 10, 2024

Great, thanks! Not for me. Perhaps @Ildest would like to look at the content(?) She hasn't worked on the label names with me yet. But you can probably start building a bit until she's back.

Thank you, I will take a look this morning :-).

@Ildest Ildest self-assigned this Dec 10, 2024
@Ildest
Copy link
Contributor

Ildest commented Dec 10, 2024

I have changed "kolonnenavn" to "kolonnetittel" in the sketches @lassopicasso and @Annikenkbrathen. I have a question about the order of things. To me, it seems more logical to set the column title first, then select the things you want in this column. Is that something we have considered here?

@Annikenkbrathen
Copy link
Author

@Ildest great!
Yes, we have considered that. The reason it works this way is that we use the label in the component you select as the title in the column title field. So, you don’t actually need to fill in the title, but if you want to change the title that appears there, it is editable.

The title and query fields will not be displayed until the component is selected anyways, I think.

Is the title "Celleinnhold (query)" okay?

@lassopicasso
Copy link
Contributor

lassopicasso commented Dec 10, 2024

@Annikenkbrathen, we currently display the title element regardless of whether a component is selected or not.
Edit: but I can change it so the title (and query) fields are not displayed until a component is selected.

Image

Similar behaviour to summary2:
Image

@Annikenkbrathen
Copy link
Author

okey, sonuds good!

@lassopicasso
Copy link
Contributor

lassopicasso commented Dec 10, 2024

@Ildest, @Annikenkbrathen

Is the title "Celleinnhold (query)" okay?

"Celleinnhold" could work, but just for your information - if I understand query correctly, in this context it refers to the data model field used to fetch the value displayed in the column cell.

okey, sonuds good!

Ok, I will hide the title and query elements until a component is selected :)

@Ildest
Copy link
Contributor

Ildest commented Dec 10, 2024

@Ildest great! Yes, we have considered that. The reason it works this way is that we use the label in the component you select as the title in the column title field. So, you don’t actually need to fill in the title, but if you want to change the title that appears there, it is editable.

The title and query fields will not be displayed until the component is selected anyways, I think.

Is the title "Celleinnhold (query)" okay?

Thank you, yes, Anniken explained that to me as well, so that´s fine then. We discussed "Celleinnhold (query)" and decided it was ok, since this field is for developers and they use the word query more than "spørring". But in general, if we can use Norwegian terms, we should.

@Annikenkbrathen
Copy link
Author

Annikenkbrathen commented Dec 11, 2024

Edit: but I can change it so the title (and query) fields are not displayed until a component is selected.
Did not see this! What do you think Is the best solution? @lassopicasso

I was thinking that since we are going to present both query and kolonnetitle as text that is added, it feels strange to show the fields as open fields that are disabled first (when it’s not required to be filled in/ or edit).
It's a bit similar to the pattern we have on texts when we select a text with a text key, and the ID is displayed below.
You won't need to do anything with the ID field.
Image

@lassopicasso lassopicasso linked a pull request Dec 19, 2024 that will close this issue
4 tasks
@lassopicasso lassopicasso moved this from 👷 In Progress to 🔎 Review in Team Studio Dec 19, 2024
@mlqn mlqn assigned mlqn and lassopicasso and unassigned mlqn Jan 10, 2025
@lassopicasso lassopicasso assigned mlqn and unassigned lassopicasso Jan 14, 2025
@mlqn mlqn assigned lassopicasso and unassigned mlqn Jan 14, 2025
@lassopicasso lassopicasso moved this from 🔎 Review to 🧪 Test in Team Studio Jan 14, 2025
@lassopicasso lassopicasso removed their assignment Jan 14, 2025
@JamalAlabdullah
Copy link
Contributor

Tested ok in dev

@github-project-automation github-project-automation bot moved this from 🧪 Test to Documentation in Team Studio Jan 14, 2025
@JamalAlabdullah JamalAlabdullah moved this from Documentation to ✅ Done in Team Studio Jan 14, 2025
@JamalAlabdullah JamalAlabdullah moved this from ✅ Done to Documentation in Team Studio Jan 14, 2025
@lassopicasso lassopicasso moved this from Documentation to ✅ Done in Team Studio Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request Feature request that will be considered. team/studio-domain2 ux UX help needed
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

5 participants