fix: remove duplicated action identifier in label (#14393)

Author: standeren

frontend/language/src/nb.json

@@ -688,7 +688,7 @@
   "process_editor.configuration_panel_actions_action_card_custom": "Lag egendefinert handling",
   "process_editor.configuration_panel_actions_action_card_custom_label": "Skriv inn navnet på handlingen du vil lage",
   "process_editor.configuration_panel_actions_action_card_title": "Handling {{actionIndex}}",
-  "process_editor.configuration_panel_actions_action_label": "Handling {{actionIndex}}: {{actionName}}",
+  "process_editor.configuration_panel_actions_action_label": "Handling {{actionIndex}}:",
   "process_editor.configuration_panel_actions_action_selector_label": "Velg en handling fra listen",
   "process_editor.configuration_panel_actions_action_tab_predefined": "Velg standard handling",
   "process_editor.configuration_panel_actions_action_type_help_text": "Hjelpetekst for å velge handlingstype",

frontend/packages/process-editor/src/components/ConfigPanel/ConfigContent/EditActions/ActionsEditor/ActionsEditor.test.tsx

@@ -21,7 +21,6 @@ describe('ActionsEditor', () => {
     const actionButton = screen.getByRole('button', {
       name: textMock('process_editor.configuration_panel_actions_action_label', {
         actionIndex: 1,
-        actionName: 'reject',
       }),
     });
     expect(actionButton).toBeInTheDocument();
@@ -40,7 +39,6 @@ describe('ActionsEditor', () => {
     const actionButton = screen.getByRole('button', {
       name: textMock('process_editor.configuration_panel_actions_action_label', {
         actionIndex: 1,
-        actionName: 'reject',
       }),
     });
     expect(actionButton).toBeInTheDocument();
@@ -52,7 +50,6 @@ describe('ActionsEditor', () => {
     const actionButton = screen.getByRole('button', {
       name: textMock('process_editor.configuration_panel_actions_action_label', {
         actionIndex: 1,
-        actionName: 'reject',
       }),
     });
 
@@ -77,7 +74,6 @@ describe('ActionsEditor', () => {
     const actionButton = screen.getByRole('button', {
       name: textMock('process_editor.configuration_panel_actions_action_label', {
         actionIndex: 1,
-        actionName: 'reject',
       }),
     });
     expect(actionButton).toBeInTheDocument();
@@ -112,7 +108,6 @@ describe('ActionsEditor', () => {
     const actionButton = screen.queryByRole('button', {
       name: textMock('process_editor.configuration_panel_actions_action_label', {
         actionIndex: 1,
-        actionName: 'reject',
       }),
     });
     expect(actionButton).not.toBeInTheDocument();

frontend/packages/process-editor/src/components/ConfigPanel/ConfigContent/EditActions/ActionsEditor/ActionsEditor.tsx

@@ -43,7 +43,6 @@ export const ActionsEditor = ({
 
   const actionLabel = t('process_editor.configuration_panel_actions_action_label', {
     actionIndex: actionIndex + 1,
-    actionName: actionElement.action,
   });
 
   if (componentMode === 'edit') {

frontend/packages/process-editor/src/components/ConfigPanel/ConfigContent/EditActions/EditActions.test.tsx

@@ -111,7 +111,6 @@ describe('EditActions', () => {
     const viewModeElement = screen.getByText(
       textMock('process_editor.configuration_panel_actions_action_label', {
         actionIndex: 1,
-        actionName: 'reject',
       }),
     );
     expect(viewModeElement).toBeInTheDocument();
@@ -159,7 +158,7 @@ describe('EditActions', () => {
       getUniqueKey: () => [],
     }));
 
-    await renderEditActions();
+    renderEditActions();
     const addButton = screen.getByRole('button', {
       name: textMock('process_editor.configuration_panel_actions_add_new'),
     });
@@ -194,7 +193,6 @@ describe('EditActions', () => {
     const viewModeElement = screen.getByText(
       textMock('process_editor.configuration_panel_actions_action_label', {
         actionIndex: 1,
-        actionName: 'reject',
       }),
     );
     expect(viewModeElement).toBeInTheDocument();

frontend/testing/playwright/pages/ProcessEditorPage/ActionsConfig.ts

@@ -63,12 +63,11 @@ export class ActionsConfig extends BasePage {
       .click();
   }
 
-  public async editAction(action: string): Promise<void> {
+  public async editAction(): Promise<void> {
     await this.page
       .getByRole('button', {
         name: this.textMock('process_editor.configuration_panel_actions_action_label', {
           actionIndex: '1',
-          actionName: action,
         }),
       })
       .click();

frontend/testing/playwright/tests/process-editor/task-actions.spec.ts

@@ -60,7 +60,7 @@ test('should be possible to remove action from task', async ({
   const giteaPage = new GiteaPage(page, { app: testAppName });
   const processEditorPage = await setupProcessEditorActionConfigPanel(page, testAppName);
 
-  await processEditorPage.actionsConfig.editAction('write');
+  await processEditorPage.actionsConfig.editAction();
 
   await processEditorPage.actionsConfig.deleteAction('write');
   await commitAndPushToGitea(page, testAppName);