fix(designer): Prevent propagation of 401 Unauthorized status from Azure DevOps (#14378)

Author: framitdavid

backend/src/Designer/TypedHttpClients/DelegatingHandlers/AzureDevOpsTokenDelegatingHandler.cs

@@ -0,0 +1,24 @@
+using System.Net;
+using System.Net.Http;
+using System.Threading;
+using System.Threading.Tasks;
+
+namespace Altinn.Studio.Designer.TypedHttpClients.DelegatingHandlers;
+
+public class AzureDevOpsTokenDelegatingHandler : DelegatingHandler
+{
+    protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
+    {
+        HttpResponseMessage response = await base.SendAsync(request, cancellationToken);
+
+        if (response.StatusCode == HttpStatusCode.Unauthorized)
+        {
+            return new HttpResponseMessage(HttpStatusCode.InternalServerError)
+            {
+                Content = new StringContent("Failed to interact with Azure DevOps. Contact system support.")
+            };
+        }
+
+        return response;
+    }
+}

backend/src/Designer/TypedHttpClients/TypedHttpClientRegistration.cs

@@ -38,6 +38,7 @@ public static class TypedHttpClientRegistration
         public static IServiceCollection RegisterTypedHttpClients(this IServiceCollection services, IConfiguration config)
         {
             services.AddHttpClient();
+            services.AddTransient<AzureDevOpsTokenDelegatingHandler>();
             services.AddTransient<EnsureSuccessHandler>();
             services.AddTransient<PlatformBearerTokenHandler>();
             services.AddAzureDevOpsTypedHttpClient(config);
@@ -70,7 +71,7 @@ private static IHttpClientBuilder AddAzureDevOpsTypedHttpClient(this IServiceCol
                 client.BaseAddress = new Uri($"{azureDevOpsSettings.BaseUri}build/builds/");
                 client.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
                 client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Basic", token);
-            }).AddHttpMessageHandler<EnsureSuccessHandler>();
+            }).AddHttpMessageHandler<AzureDevOpsTokenDelegatingHandler>().AddHttpMessageHandler<EnsureSuccessHandler>();
         }
 
         private static IHttpClientBuilder AddKubernetesWrapperTypedHttpClient(this IServiceCollection services)

backend/tests/Designer.Tests/TypedHttpClients/DelegatingHandlers/AzureDevOpsTokenDelegatingHandlerTests.cs

@@ -0,0 +1,70 @@
+using System.Net;
+using System.Net.Http;
+using System.Threading;
+using System.Threading.Tasks;
+using Altinn.Studio.Designer.TypedHttpClients.DelegatingHandlers;
+using Moq;
+using Moq.Protected;
+using Xunit;
+
+public class AzureDevOpsTokenDelegatingHandlerTests
+{
+    [Fact]
+    public async Task SendAsync_WhenUnauthorized_ThrowsHttpRequestException()
+    {
+        // Arrange
+        var mockInnerHandler = new Mock<HttpMessageHandler>();
+
+        mockInnerHandler.Protected()
+            .Setup<Task<HttpResponseMessage>>("SendAsync",
+                ItExpr.IsAny<HttpRequestMessage>(),
+                ItExpr.IsAny<CancellationToken>())
+            .ReturnsAsync(new HttpResponseMessage
+            {
+                StatusCode = HttpStatusCode.Unauthorized
+            });
+
+        var handler = new AzureDevOpsTokenDelegatingHandler
+        {
+            InnerHandler = mockInnerHandler.Object
+        };
+
+        HttpClient httpClient = new HttpClient(handler);
+        HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Get, "https://dev.azure.com");
+
+        HttpResponseMessage response = await httpClient.SendAsync(request);
+        string content = await response.Content.ReadAsStringAsync();
+
+        Assert.Equal("Failed to interact with Azure DevOps. Contact system support.", content);
+        Assert.Equal(HttpStatusCode.InternalServerError, response.StatusCode);
+    }
+
+    [Fact]
+    public async Task SendAsync_WhenSuccessful_ReturnsResponse()
+    {
+        var mockInnerHandler = new Mock<HttpMessageHandler>();
+
+        mockInnerHandler.Protected()
+            .Setup<Task<HttpResponseMessage>>("SendAsync",
+                ItExpr.IsAny<HttpRequestMessage>(),
+                ItExpr.IsAny<CancellationToken>())
+            .ReturnsAsync(new HttpResponseMessage
+            {
+                StatusCode = HttpStatusCode.OK,
+                Content = new StringContent("Success")
+            });
+
+        var handler = new AzureDevOpsTokenDelegatingHandler
+        {
+            InnerHandler = mockInnerHandler.Object
+        };
+
+        HttpClient httpClient = new HttpClient(handler);
+        HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Get, "https://dev.azure.com");
+
+        HttpResponseMessage response = await httpClient.SendAsync(request);
+
+        Assert.Equal(HttpStatusCode.OK, response.StatusCode);
+        Assert.Equal("Success", await response.Content.ReadAsStringAsync());
+    }
+}