Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Editor removes data-tests #1467

Open
1 task
septponf opened this issue Oct 16, 2024 · 0 comments
Open
1 task

Documentation Editor removes data-tests #1467

septponf opened this issue Oct 16, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@septponf
Copy link

septponf commented Oct 16, 2024

Expected behavior

Documentation editor should handle data-tests properly

Actual behavior

The editor seems to have problem with the combination of data-tests and quote setting.
When quote is present, the editor does not identify that there are tests present. And if a comment is edited and saved, the tests will be removed from yml file.

Steps To Reproduce

models:
  - name: model_tests_works_in_editor
    description: xx
    columns:
      - name: id
        description: primary key
        data_type: string
        data_tests:
          - not_null
          - unique
  - name: model_tests_does_not_work_in_editor
    description: xx
    columns:
      - name: id
        description: primary key
        data_type: string
        data_tests:
          - not_null
          - unique
        quote: true

Log output/Screenshots

No response

Operating System

Windows 10

dbt version

1.8.5

dbt Adapter

dbt-databricks

dbt Power User version

0.47.2

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@septponf septponf added the bug Something isn't working label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants