We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It appears active is always false at that point, in which case the call is redundant and can be removed:
active
FXGL/fxgl-entity/src/main/java/com/almasb/fxgl/entity/Entity.java
Lines 188 to 191 in bbf2bb9
I have looked at call sites for clean() in GameWorld and they are always preceded by marForRemoval()
clean()
marForRemoval()
Lines 259 to 262 in bbf2bb9
So, active is false. This code is in a robust-critical section, so I'd like a second review.
@adambocco could you double check the clean() call sites and see if it is somehow possible for active to be true before it reaches clean.
The text was updated successfully, but these errors were encountered:
8ea6b75
AlmasB
No branches or pull requests
It appears
active
is always false at that point, in which case the call is redundant and can be removed:FXGL/fxgl-entity/src/main/java/com/almasb/fxgl/entity/Entity.java
Lines 188 to 191 in bbf2bb9
I have looked at call sites for
clean()
in GameWorld and they are always preceded bymarForRemoval()
FXGL/fxgl-entity/src/main/java/com/almasb/fxgl/entity/Entity.java
Lines 259 to 262 in bbf2bb9
So,
active
is false. This code is in a robust-critical section, so I'd like a second review.@adambocco could you double check the
clean()
call sites and see if it is somehow possible foractive
to be true before it reaches clean.The text was updated successfully, but these errors were encountered: