SubScene as view component?

[chengenzhao]

Hi:

We are testing 3d rendering of FXGL now
and used GameSubScene before, it works great
but it seems like SubScene of JavaFX itself is a node which can be used as view component
and after testing it works
so is it a good idea that extend SubScene as view component to mix 2D and 3D games?

Thanks

[AlmasB]

As long as it provides the required functionality, it should be fine. I suppose the difference is that the JavaFX SubScene does not have integration with the FXGL's internal systems, e.g. Timer, SceneService, etc. Not sure if it has any effect on your use case.

[chengenzhao]

what if we make a class extends SubScene and also com.almasb.fxgl.core.View?
then will it be automatically integrated to the current FXGL system?

[chengenzhao]

And seems like we could make several similar view components in this pattern
like if we want to make 2D material then we could have a class extends Canvas and also implements View like this

package com.whitewoodcity.fxgl.material;

import com.almasb.fxgl.core.Copyable;
import com.almasb.fxgl.core.View;
import javafx.scene.Node;
import javafx.scene.canvas.Canvas;
import javafx.scene.paint.Color;

public class Material extends Canvas implements View, Copyable<Material> {

  public Material(double width, double height) {
    super(width, height);
    // Redraw canvas when size changes.
    widthProperty().addListener(e -> draw());
    heightProperty().addListener(e -> draw());
  }

  public void draw() {
  }

  @Override
  public boolean isResizable() {
    return true;
  }

  protected void fillSVGPath(String webColor, String svgPath) {
    var gc = getGraphicsContext2D();
    gc.setFill(Color.web(webColor));
    gc.beginPath();
    gc.appendSVGPath(svgPath);
    gc.fill();
  }

  @Override
  public Material copy() {
    return new Material(getWidth(), getHeight());
  }

  @Override
  public Node getNode() {
    return this;
  }

  @Override
  public void dispose() {

  }

  @Override
  public void onUpdate(double tpf) {

  }
}

[chengenzhao]

and

package com.whitewoodcity.fxgl.sub3dview;

import com.almasb.fxgl.core.Copyable;
import com.almasb.fxgl.core.View;
import javafx.scene.Node;
import javafx.scene.Parent;
import javafx.scene.SceneAntialiasing;
import javafx.scene.SubScene;

public class Sub3DView extends SubScene implements View, Copyable<Sub3DView> {
  public Sub3DView(Parent root, double width, double height) {
    super(root, width, height);
  }

  public Sub3DView(Parent root, double width, double height, boolean depthBuffer, SceneAntialiasing sceneAntialiasing) {
    super(root, width, height, depthBuffer, sceneAntialiasing);
  }

  @Override
  public Sub3DView copy() {
    return new Sub3DView(getRoot(), getWidth(), getHeight(), isDepthBuffer(), getAntiAliasing());
  }

  @Override
  public Node getNode() {
    return this;
  }

  @Override
  public void dispose() {
    
  }

  @Override
  public void onUpdate(double tpf) {

  }
}