Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional sound effects for the Launcher #98

Closed
AkiraArtuhaxis opened this issue May 14, 2023 · 2 comments
Closed

Optional sound effects for the Launcher #98

AkiraArtuhaxis opened this issue May 14, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@AkiraArtuhaxis
Copy link
Contributor

The launcher should have the option to play sound effects when hovering over the banners, clicking them, going back from the info tab and opening a game. These should be enabled or disabled by default depending on the server. Below is a mockup of how I think should play:
https://github.com/AlexisL61/JackboxUtility/assets/93792993/5d34e56d-3dab-44e0-ad24-ed1aa04b83fc
Now, about how to toggle the enabling/disabling of them, I'd really like it to be in the Launcher part itself and NOT in the Settings part. Not only because this setting is for the Launcher only, but also because it really wouldn't take much space if it's one of the buttons at the bottom like the hide unowned games button. Also because the Settings...doesn't really have like a "Toggles" tab, so it'd look really out of place and unnoticed.
SFXOptionMockup

@DerErizzle
Copy link
Contributor

As discussed earlier, sfx are a big no-no. I've asked others about their opinion on this and all of them agreed. This app should not become more of a game by adding sfx. Also, like Alexis mentioned earlier, having a setting not in... the settings, is super unintuitive. I get that it's only for the launcher, but it has nothing to do with filtering and searching for games, which is the purpose of the section on the left. Also adding that if you want to include this, you don't want to toggle it off and on anytime, so I don't see a problem with this being "more hidden" in the settings. For the German server, we definitely don't want this feature

@AlexisL61 AlexisL61 added this to the 1.3.0 milestone May 14, 2023
@AlexisL61 AlexisL61 added the enhancement New feature or request label May 14, 2023
@AkiraArtuhaxis
Copy link
Contributor Author

AkiraArtuhaxis commented May 22, 2023

As discussed earlier, sfx are a big no-no. I've asked others about their opinion on this and all of them agreed. This app should not become more of a game by adding sfx. Also, like Alexis mentioned earlier, having a setting not in... the settings, is super unintuitive. I get that it's only for the launcher, but it has nothing to do with filtering and searching for games, which is the purpose of the section on the left. Also adding that if you want to include this, you don't want to toggle it off and on anytime, so I don't see a problem with this being "more hidden" in the settings. For the German server, we definitely don't want this feature

This definitely varies by community, as in my server not a single person said "No" to the sound effects. If the option doesn't look out of place, it can be in the Settings. And it can stay in the Settings on every server. Only the option to leave it on or off by default would vary depending on the server. So if a German user wants to enable them, they can. The option doesn't need to be hidden entirely depending on the server.

AlexisL61 added a commit that referenced this issue Jul 2, 2023
AlexisL61 added a commit that referenced this issue Jul 2, 2023
AlexisL61 added a commit that referenced this issue Jul 2, 2023
@AlexisL61 AlexisL61 self-assigned this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants