-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional sound effects for the Launcher #98
Comments
As discussed earlier, sfx are a big no-no. I've asked others about their opinion on this and all of them agreed. This app should not become more of a game by adding sfx. Also, like Alexis mentioned earlier, having a setting not in... the settings, is super unintuitive. I get that it's only for the launcher, but it has nothing to do with filtering and searching for games, which is the purpose of the section on the left. Also adding that if you want to include this, you don't want to toggle it off and on anytime, so I don't see a problem with this being "more hidden" in the settings. For the German server, we definitely don't want this feature |
This definitely varies by community, as in my server not a single person said "No" to the sound effects. If the option doesn't look out of place, it can be in the Settings. And it can stay in the Settings on every server. Only the option to leave it on or off by default would vary depending on the server. So if a German user wants to enable them, they can. The option doesn't need to be hidden entirely depending on the server. |
The launcher should have the option to play sound effects when hovering over the banners, clicking them, going back from the info tab and opening a game. These should be enabled or disabled by default depending on the server. Below is a mockup of how I think should play:
![SFXOptionMockup](https://private-user-images.githubusercontent.com/93792993/238163987-23b9e8b4-84e2-4839-86fa-455be34c0d6f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3MDE3MzksIm5iZiI6MTczOTcwMTQzOSwicGF0aCI6Ii85Mzc5Mjk5My8yMzgxNjM5ODctMjNiOWU4YjQtODRlMi00ODM5LTg2ZmEtNDU1YmUzNGMwZDZmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDEwMjM1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYzNTY4NzE3MmE5NDIyZmFjZDI1NzFiZGU3OGE2MjViMGI1MGFjY2M3NDc0ZTY1NTMzZGFkZDE2MWU4OTJjMTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.EQXyLjX1C26Rn-zbLa3rhQQ-j6ZKbWXXXC7-nCdJt1c)
https://github.com/AlexisL61/JackboxUtility/assets/93792993/5d34e56d-3dab-44e0-ad24-ed1aa04b83fc
Now, about how to toggle the enabling/disabling of them, I'd really like it to be in the Launcher part itself and NOT in the Settings part. Not only because this setting is for the Launcher only, but also because it really wouldn't take much space if it's one of the buttons at the bottom like the hide unowned games button. Also because the Settings...doesn't really have like a "Toggles" tab, so it'd look really out of place and unnoticed.
The text was updated successfully, but these errors were encountered: