Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFX tweaks #206

Closed
12 tasks done
AkiraArtuhaxis opened this issue Jul 2, 2023 · 2 comments
Closed
12 tasks done

SFX tweaks #206

AkiraArtuhaxis opened this issue Jul 2, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@AkiraArtuhaxis
Copy link
Contributor

AkiraArtuhaxis commented Jul 2, 2023

The same SFX that plays when you click a star should play:

  • When you press the "Hide game" button.
  • When you press a filter toggle.
  • When you press the arrow to change sorting.
  • When you press the "Show games you've hidden" button.
  • When you press the "Show unowned games" button.
  • The same SFX that plays when you hover over a star should play when you hover over a Filter button.
  • The SFX when you go enter a game info tab should play when you press one of the clickable buttons from each game info tab (Translated by the community, tags, etc).
  • The SFX when you go back from the game info tab should play when you go back from the Launcher to the title screen for consistency.
  • The SFX when you go back from the game info tab should play when you go back after pressing the clickable buttons from each game info tab (Translated by the community, tags, etc).
  • If possible, I'd also make it so the play button SFX begins playing as soon as you click the button and not when the game starts launching.
  • On the "Random" tab, every time a banner gets shuffled in the "Let's try another one!" animation the hover over banner SFX should play.
  • When opening and closing the Filter menu, I suggest these SFX: sfx.zip
@AlexisL61 AlexisL61 added this to the 1.3.0 milestone Jul 2, 2023
@AlexisL61 AlexisL61 added the enhancement New feature or request label Jul 2, 2023
AlexisL61 added a commit that referenced this issue Jul 3, 2023
@AkiraArtuhaxis
Copy link
Contributor Author

AkiraArtuhaxis commented Jul 3, 2023

  • When you leave the "Random game" tab, the hover SFX plays. This shouldn't be the case.
  • Sometimes, when filters are applied, the random shuffle SFX gets either cut or replaced by one of the SFX from the Filter. This shouldn't be the case and only the shuffle SFX should play.
  • Make "click" SFX (when clicking on Stars, hidden game button, etc) not able to be cut by other SFX.
  • Make hover and "click" SFX when you hover/click the button to remove all filters.
  • Make "leave" SFX (when you go back from a game info tab) not able to be cut by other SFX.
  • "Leave" SFX doesn't play when you press ESC on the buttons from the game info tabs (Translated by the community, Coop, etc). It does play when you click the back button. It should play in both cases.
  • When you click a Star, that same Star you're hovering on shouldn't play a SFX when you move the mouse. Only when you hover over one of the ones next to it it should play.
  • When you open the "Sort by" menu, the SFX when you open the filter should play.
  • When you don't select a sorting (press outside the button), the SFX when you close the filter should play.
  • When clicking the tabs on the sidebar (and the games appear), I suggest this SFX: sfx.zip
  • "Play" SFX gets played twice now.
  • "Play" SFX shouldn't get interrupted.
  • Replace close game info tab SFX with this: sfx.zip

@AlexisL61
Copy link
Member

The checkbox that are not checked cannot be done right now

AlexisL61 added a commit that referenced this issue Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants