Add data and document to dev genesis block identifier #3409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkxuerb
approved these changes
Nov 18, 2024
Thx, merging in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Due to #3378 the development genesis block changes. However, this took longer than I dare to admit to realise, because my tests still retrieved the old genesis block based on an incomplete identifier.
This PR incorporates the minor learnings into the codebase for future developers: added the trait variables which are subject to change to the ephemeral dev block identifier, and some documentation.
Test Plan
Tested using
devnet.sh, dev nodes still start as expected. This change only impacts--devmode.