Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility check to js-controller 4.0 #707

Closed
ioBrokerChecker opened this issue Feb 8, 2022 · 7 comments · Fixed by #730
Closed

Compatibility check to js-controller 4.0 #707

ioBrokerChecker opened this issue Feb 8, 2022 · 7 comments · Fixed by #730

Comments

@ioBrokerChecker
Copy link

Dear Adapter developer,

with js-controller 4.0 object definitions are now also checked that min/max in only provided for number/mixed objects and that the type of the default value matches to the object type.

If something is not correct this is logged as 'warning' or 'info' log.

Please also make sure to update to the lastest @iobroker/testing dependency 2.5.4 or to accept the PR from Apollon77 for legacy testing!

Please spent some time to verify your adapter by ideally starting with a fresh instance and do some actions and verify the log. If you see a warn or info log there from these checks please adjust the adapter and fix the relevant cases.

For questions please refer to ioBroker/ioBroker.js-controller#1749

Please close the issue after you checked it.

Thank you very much for your support to get the best experience for the growing numbers of ioBroker users!

@asutpshnik
Copy link

Now the version is not compatible with js-controller 4.0.9
After starting BLE driver, cyclic attempts to rebuild npm components/libs
By updating js-controller, I received a non-working driver, the ble sensors are not polled (((

@AlCalzone
Copy link
Owner

This is a bug in js-controller that has already been fixed: ioBroker/ioBroker.js-controller#1805

If you're participating in a beta-test, this can always happen.

@Apollon77
Copy link
Contributor

@asutpshnik Ok, now one step after the other.

1.) an npm rebuild issue only happens when you upgrade nodejs ... this has nothing to do with the js-controller
2.) Yes, one library used inside ble adapter do not allow a proper rebuild of itself. This is nothing te adapter can do anything. We alreay work with the library owner to get an update to enhance this.
3.) After 3 rebuild tries the log contain exact details on how to fix it yourself, please read the logs. In fact yu need to run "npm install -- production" inside /opt/iobroker/node_modules/iobroker.ble - this should fix this issue temporariely

@Apollon77
Copy link
Contributor

For completeness: This is the "fix" we need in that one library abandonware/node-bluetooth-hci-socket#39 ... The PR is already merged, just the release is pending ... and before someone complains that also canvas is affected ... yes it has the same issue Automattic/node-canvas#1982 (PR still open, likes there welcome)

@asutpshnik
Copy link

asutpshnik commented Feb 15, 2022

3.) After 3 rebuild tries the log contain exact details on how to fix it yourself, please read the logs. In fact yu need to run "npm install -- production" inside /opt/iobroker/node_modules/iobroker.ble - this should fix this issue temporariely

3.) - helped me, the driver starts up and works, thanks!

@Apollon77
Copy link
Contributor

@asutpshnik Thank you for your info. We hope to get the library update soon then it should be better in the future

@TDCroPower
Copy link

here too, with the command in the correct directory the adapter works again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants