We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using S3Transfer with host being an IPv6 address such as ::1 Rohmu fails. This can happen when using a "non-S3 S3" such as MinIO and IPv6.
S3Transfer
host
::1
The exact reason of the failure is here:
rohmu/rohmu/object_storage/s3.py
Line 155 in a9aea97
According to RFC 2732
To use a literal IPv6 address in a URL, the literal address should be enclosed in "[" and "]" characters.
Obviously, the code doesn't do this.
I tried with a simple change and Rohmu seems to work.
custom_url = f"{scheme}://[{host}]:{port}"
The text was updated successfully, but these errors were encountered:
No branches or pull requests
When using
S3Transfer
withhost
being an IPv6 address such as::1
Rohmu fails. This can happen when using a "non-S3 S3" such as MinIO and IPv6.The exact reason of the failure is here:
rohmu/rohmu/object_storage/s3.py
Line 155 in a9aea97
According to RFC 2732
Obviously, the code doesn't do this.
I tried with a simple change and Rohmu seems to work.
The text was updated successfully, but these errors were encountered: