Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Removing a Testset that is referenced by an Evaluation Model causes an Internal Server Error #863

Closed
aybruhm opened this issue Nov 3, 2023 · 1 comment
Assignees
Labels
Backend bug Something isn't working dev experience Improvement of the experience using the software. For instance better error messaging Frontend

Comments

@aybruhm
Copy link
Member

aybruhm commented Nov 3, 2023

Describe the bug
When you remove a testset that is in use by an evaluation, it causes an internal server error when you go to the evaluation page.

To Reproduce
Steps to reproduce the behavior:

  1. Create any evaluation with any testset of your choice
  2. Navigate to the testset page, and delete the testset that is in use
  3. Navigate to the evaluations page, you'll get: "Internal Server Error"

Expected behavior
A modal should be displayed that tells users that deleting the testset will change the testset to a dummy testset in the evaluation using the testset being deleted.

@aybruhm aybruhm added bug Something isn't working dev experience Improvement of the experience using the software. For instance better error messaging Backend labels Nov 3, 2023
@mmabrouk
Copy link
Member

  • We have decided to solve this issue by disallowing users to remove testsets used by evaluations.
  • The expected behavior is show a modal letting the users know that they cannot do this action unless they remove a certain list of evaluations

@aakrem aakrem closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend bug Something isn't working dev experience Improvement of the experience using the software. For instance better error messaging Frontend
Projects
None yet
4 participants