Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments to build-scripts #2110

Closed
M-Davies opened this issue Oct 1, 2020 · 1 comment · Fixed by #2163
Closed

Add comments to build-scripts #2110

M-Davies opened this issue Oct 1, 2020 · 1 comment · Fixed by #2163
Assignees
@M-Davies
Labels
documentation Issues that request updates to our documentation enhancement Issues that enhance the code or documentation of the repo in any way
Milestone
October 2020

Comments

@M-Davies
Copy link

M-Davies commented Oct 1, 2020 •
edited
Loading

Pretty self explanatory, we need comments on each function and/or sections of importance inside the pipelines folder to ease newcomers into the codebase.
@M-Davies M-Davies added enhancement Issues that enhance the code or documentation of the repo in any way documentation Issues that request updates to our documentation handy/helpful/gives ease good first issue - candidate This label defines that the issues can become a "good first issue" - must be reviewed labels Oct 1, 2020
@hendrikebbers
Copy link
Member

@M-Davies I assume that this issue is to complexe for a good first issue. A newcomer has no idea about the functionality about that methods. But having such comments are really important to help newcomers to get into the project :) I would remove the 'good first issue - candidate" label for this issue.

@M-Davies M-Davies removed the good first issue - candidate This label defines that the issues can become a "good first issue" - must be reviewed label Oct 19, 2020
@M-Davies M-Davies mentioned this issue Oct 20, 2020
Merged
@M-Davies M-Davies self-assigned this Oct 20, 2020
@karianna karianna added this to the October 2020 milestone Oct 27, 2020
@sxa sxa mentioned this issue Oct 30, 2020
Open
@M-Davies M-Davies mentioned this issue Nov 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@M-Davies M-Davies

Labels
documentation Issues that request updates to our documentation enhancement Issues that enhance the code or documentation of the repo in any way
Projects
None yet
Milestone
October 2020
Development

Successfully merging a pull request may close this issue.

Comment and styling cleanup M-Davies/openjdk-build
3 participants
@karianna @hendrikebbers @M-Davies