Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SceneNodeList "type" should move to scenegraph.d.ts #52

Closed
ericdrobinson opened this issue Jun 28, 2019 · 2 comments · Fixed by #51
Closed

SceneNodeList "type" should move to scenegraph.d.ts #52

ericdrobinson opened this issue Jun 28, 2019 · 2 comments · Fixed by #51
Assignees
Labels
enhancement New feature or request

Comments

@ericdrobinson
Copy link

The SceneNodeList class should not be in the global context. Actual attempts to access the SceneNodeList directly in a command script results in undefined (it's not actually a global).

Further, this should probably be an interface rather than a class as there does not appear to be a way to create new instances yourself.

Therefore I would recommend moving the SceneNodeList declaration into scenegraph.d.ts, (the only location the type is actually referenced) and simultaneously convert it to an interface.

pklaschka added a commit that referenced this issue Jun 29, 2019
@pklaschka pklaschka self-assigned this Jun 29, 2019
@pklaschka
Copy link
Contributor

I've done this in the mega PR as well in order to not have many releases for this version. I'll (really) merge it later today (unless you open yet another issue that can get fixed with this PR 😉).

@pklaschka pklaschka added the enhancement New feature or request label Jun 29, 2019
@ericdrobinson
Copy link
Author

unless you open yet another issue that can get fixed with this PR 😉

Hold onto your pants... 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants