(chocolatey#2469) Remove deprecated Write-ChocolateySuccess

This function was deprecated is meant to be removed
in v1.0.0.
This commit removes this function, and all usages of
the functions. There may need to be updates in other
locations outside of this repository that do similar
changes.

Author: AdmiringWorm

GenerateDocs.ps1

@@ -57,13 +57,6 @@ These functions call other functions and many times may be the only thing you ne
 * [Install-ChocolateyPowershellCommand](xref:install-chocolateypowershellcommand)
 * [Install-ChocolateyVsixPackage](xref:install-chocolateyvsixpackage)
 
-## Error / Success Functions
-
-* [Write-ChocolateySuccess](xref:write-chocolateysuccess) - **DEPRECATED**
-* [Write-ChocolateyFailure](xref:write-chocolateyfailure) - **DEPRECATED**
-
-You really don't need a try catch with Chocolatey PowerShell files anymore.
-
 ## More Functions
 
 ### Administrative Access Functions
@@ -86,7 +79,6 @@ These are the functions from above as one list.
 
 * [Install-ChocolateyZipPackage](xref:install-chocolateyzippackage)
 * [Install-ChocolateyPowershellCommand](xref:install-chocolateypowershellcommand)
-* [Write-ChocolateySuccess](xref:write-chocolateysuccess)
 * [Write-ChocolateyFailure](xref:write-chocolateyfailure)
 * [Get-ChocolateyWebFile](xref:get-chocolateywebfile)
 * [Get-ChocolateyUnzip](xref:get-chocolateyunzip)

src/chocolatey.resources/chocolatey.resources.csproj

@@ -86,7 +86,6 @@
     <EmbeddedResource Include="helpers\functions\UnInstall-ChocolateyZipPackage.ps1" />
     <EmbeddedResource Include="helpers\functions\Update-SessionEnvironment.ps1" />
     <EmbeddedResource Include="helpers\functions\Write-ChocolateyFailure.ps1" />
-    <EmbeddedResource Include="helpers\functions\Write-ChocolateySuccess.ps1" />
     <EmbeddedResource Include="redirects\choco.exe.ignore" />
     <EmbeddedResource Include="redirects\chocolatey.exe.ignore" />
     <EmbeddedResource Include="redirects\cinst.exe.ignore" />

src/chocolatey.resources/helpers/functions/Write-ChocolateyFailure.ps1

@@ -43,9 +43,6 @@ The message to throw an error with.
 
 .PARAMETER IgnoredArguments
 Allows splatting with arguments that do not apply. Do not use directly.
-
-.LINK
-Write-ChocolateySuccess
 #>
 param(
   [string] $packageName,

src/chocolatey.resources/helpers/functions/Write-ChocolateySuccess.ps1

@@ -1,20 +1,13 @@
 $toolsDir = "$(Split-Path -parent $MyInvocation.MyCommand.Definition)"
 
-try {
-  "simple file" | Out-File "$toolsDir\simplefile.txt" -force
+"simple file" | Out-File "$toolsDir\simplefile.txt" -force
 
-  Write-Output "This is $packageName v$packageVersion being installed to `n '$packageFolder'."
-  Write-Host "PowerShell Version is '$($PSVersionTable.PSVersion)' and CLR Version is '$($PSVersionTable.CLRVersion)'."
-  Write-Host "Execution Policy is '$(Get-ExecutionPolicy)'."
-  Write-Host "PSScriptRoot is '$PSScriptRoot'."
-  Write-Debug "A debug message."
-  Write-Verbose "Yo!"
-  Write-Warning "A warning!"
-  Write-Error "Oh no! An error"
-  throw "We had an error captain!"
-
-  Write-ChocolateySuccess "$packageName"
-} catch {
-  Write-ChocolateyFailure "$packageName" "$($_.Exception.Message)"
-  throw
-}
+Write-Output "This is $packageName v$packageVersion being installed to `n '$packageFolder'."
+Write-Host "PowerShell Version is '$($PSVersionTable.PSVersion)' and CLR Version is '$($PSVersionTable.CLRVersion)'."
+Write-Host "Execution Policy is '$(Get-ExecutionPolicy)'."
+Write-Host "PSScriptRoot is '$PSScriptRoot'."
+Write-Debug "A debug message."
+Write-Verbose "Yo!"
+Write-Warning "A warning!"
+Write-Error "Oh no! An error"
+throw "We had an error captain!"

src/chocolatey.tests.integration/context/badpackage/1.0/tools/chocolateyInstall.ps1

@@ -1,15 +1,7 @@
 $packageName = 'badpackage'
 
-try {
-
-  Write-Host "Ya!"
-  Write-Debug "A debug message"
-  Write-Warning "A warning!"
-  Write-Error "Oh no! An error"
-  throw "We had an error captain!"
-
-  Write-ChocolateySuccess "$packageName"
-} catch {
-  Write-ChocolateyFailure "$packageName" "$($_.Exception.Message)"
-  throw
-}
+Write-Host "Ya!"
+Write-Debug "A debug message"
+Write-Warning "A warning!"
+Write-Error "Oh no! An error"
+throw "We had an error captain!"

src/chocolatey.tests.integration/context/badpackage/1.0/tools/chocolateyUninstall.ps1

@@ -1,17 +1,9 @@
-try {
-
- Write-Output "This is $packageName v$packageVersion being installed to `n '$packageFolder'."
-  Write-Host "PowerShell Version is '$($PSVersionTable.PSVersion)' and CLR Version is '$($PSVersionTable.CLRVersion)'."
-  Write-Host "Execution Policy is '$(Get-ExecutionPolicy)'."
-  Write-Host "PSScriptRoot is '$PSScriptRoot'."
-  Write-Debug "A debug message."
-  Write-Verbose "Yo!"
-  Write-Warning "A warning!"
-  Write-Error "Oh no! An error"
-  throw "We had an error captain!"
-
-  Write-ChocolateySuccess "$packageName"
-} catch {
-  Write-ChocolateyFailure "$packageName" "$($_.Exception.Message)"
-  throw
-}
+Write-Output "This is $packageName v$packageVersion being installed to `n '$packageFolder'."
+Write-Host "PowerShell Version is '$($PSVersionTable.PSVersion)' and CLR Version is '$($PSVersionTable.CLRVersion)'."
+Write-Host "Execution Policy is '$(Get-ExecutionPolicy)'."
+Write-Host "PSScriptRoot is '$PSScriptRoot'."
+Write-Debug "A debug message."
+Write-Verbose "Yo!"
+Write-Warning "A warning!"
+Write-Error "Oh no! An error"
+throw "We had an error captain!"

src/chocolatey.tests.integration/context/badpackage/2.0/tools/chocolateyInstall.ps1

@@ -1,15 +1,7 @@
 $packageName = 'badpackage'
 
-try {
-
-  Write-Host "Ya!"
-  Write-Debug "A debug message"
-  Write-Warning "A warning!"
-  Write-Error "Oh no! An error"
-  throw "We had an error captain!"
-
-  Write-ChocolateySuccess "$packageName"
-} catch {
-  Write-ChocolateyFailure "$packageName" "$($_.Exception.Message)"
-  throw
-}
+Write-Host "Ya!"
+Write-Debug "A debug message"
+Write-Warning "A warning!"
+Write-Error "Oh no! An error"
+throw "We had an error captain!"