From 6d3865239702c3fbe848e98393243088c6d47042 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Mon, 17 Oct 2022 20:03:24 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- .../python/mxnet/contrib/text/embedding.py | 21 ++++++++++++++++++- .../mxnet/gluon/data/vision/datasets.py | 21 ++++++++++++++++++- .../nightly/estimator/test_sentiment_rnn.py | 21 ++++++++++++++++++- .../tests/python/gpu/test_forward.py | 21 ++++++++++++++++++- 4 files changed, 80 insertions(+), 4 deletions(-) diff --git a/incubator-mxnet-master/python/mxnet/contrib/text/embedding.py b/incubator-mxnet-master/python/mxnet/contrib/text/embedding.py index 952b664..0bce04e 100644 --- a/incubator-mxnet-master/python/mxnet/contrib/text/embedding.py +++ b/incubator-mxnet-master/python/mxnet/contrib/text/embedding.py @@ -226,7 +226,26 @@ def _get_pretrained_file(cls, embedding_root, pretrained_file_name): zf.extractall(embedding_dir) elif ext == '.gz': with tarfile.open(downloaded_file_path, 'r:gz') as tar: - tar.extractall(path=embedding_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=embedding_dir) return pretrained_file_path def _load_embedding(self, pretrained_file_path, elem_delim, init_unknown_vec, encoding='utf8'): diff --git a/incubator-mxnet-master/python/mxnet/gluon/data/vision/datasets.py b/incubator-mxnet-master/python/mxnet/gluon/data/vision/datasets.py index bdcaff5..001f0e1 100644 --- a/incubator-mxnet-master/python/mxnet/gluon/data/vision/datasets.py +++ b/incubator-mxnet-master/python/mxnet/gluon/data/vision/datasets.py @@ -177,7 +177,26 @@ def _get_data(self): sha1_hash=self._archive_file[1]) with tarfile.open(filename) as tar: - tar.extractall(self._root) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, self._root) if self._train: data_files = self._train_data diff --git a/incubator-mxnet-master/tests/nightly/estimator/test_sentiment_rnn.py b/incubator-mxnet-master/tests/nightly/estimator/test_sentiment_rnn.py index 367c69b..1c13bf7 100644 --- a/incubator-mxnet-master/tests/nightly/estimator/test_sentiment_rnn.py +++ b/incubator-mxnet-master/tests/nightly/estimator/test_sentiment_rnn.py @@ -128,7 +128,26 @@ def download_imdb(data_dir='/tmp/data'): if not os.path.isfile(file_path): file_path = gluon.utils.download(url, data_dir, sha1_hash=sha1) with tarfile.open(file_path, 'r') as f: - f.extractall(data_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f, data_dir) def read_imdb(folder='train'): diff --git a/incubator-mxnet-master/tests/python/gpu/test_forward.py b/incubator-mxnet-master/tests/python/gpu/test_forward.py index 2ec5ee2..d376ba6 100644 --- a/incubator-mxnet-master/tests/python/gpu/test_forward.py +++ b/incubator-mxnet-master/tests/python/gpu/test_forward.py @@ -30,7 +30,26 @@ def _get_model(): if not os.path.exists('model/Inception-7-symbol.json'): download('http://data.mxnet.io/models/imagenet/inception-v3.tar.gz') with tarfile.open(name="inception-v3.tar.gz", mode="r:gz") as tf: - tf.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tf) def _dump_images(shape): import skimage.io