Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option for custom service defenition from the config. #3076

Closed
3 tasks done
kisst opened this issue May 5, 2021 · 1 comment
Closed
3 tasks done

Provide option for custom service defenition from the config. #3076

kisst opened this issue May 5, 2021 · 1 comment
Labels
duplicate Duplicate or merged issues.

Comments

@kisst
Copy link

kisst commented May 5, 2021

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Problem Description

Handling per client rules in custom rules is possible, but not too handy in practice due to the complex rule expressions.
The list of services defined is short, and not extendable.

Proposed Solution

Allow users to extend the internal/dnsfilter/blocked.go serviceRulesArray with custom definitions, even better if this can be consumed like the block list itself, aka based on a feed.

Specific use-case, blocking CDN access to any CSS JS etc static lib which with browser plugin can be injected back into cache so page functionality does not break, hence it can be blocked on DNS level, but for clients where this is not an option, this "service" should be enabled, OR an other specific use-case is connectivity check endpoints, most of the device talk home with performing "am I online" connectivity checks, this can be by default blocked, but some devices will just drop the connection if they don't "think" that they are online, so having this defined as a service, would make it easy to switch on and off.

Alternatives Considered

The current way to do this now, is use labels, and label specific rules, which works ™️ but pretty complex to handle.

Additional Information

Icons, and etc in case custom service definitions can be generic.

@ameshkov ameshkov added duplicate Duplicate or merged issues. and removed feature request labels May 7, 2021
@ameshkov
Copy link
Member

ameshkov commented May 7, 2021

Duplicates #1692

@ameshkov ameshkov closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Duplicate or merged issues.
Projects
None yet
Development

No branches or pull requests

3 participants