Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/REGRESSION] 2ch.hk parsing is broken #829

Closed
K1rakishou opened this issue Mar 21, 2020 · 0 comments
Closed

[BUG/REGRESSION] 2ch.hk parsing is broken #829

K1rakishou opened this issue Mar 21, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@K1rakishou
Copy link

K1rakishou commented Mar 21, 2020

Namely here: 551c97d#diff-a6ea4f84b562cfcf22f06c879c78fda8R215

There is no "break" operator after md5 string is extracted so it skips the next name which breaks everything.

Also, 2ch.hk already sends the md5 parameter as a normal string (it's not base64 encoded) so we don't need to decode it.

public Builder fileHash(String fileHash) {
    if (!TextUtils.isEmpty(fileHash)) {
        this.fileHash = StringUtils.decodeBase64(fileHash);
    }

    return this;
 }
@K1rakishou K1rakishou added the bug Something isn't working label Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant