Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joint Tour Destination Changed to Use Non-Mandatory Destination Choice Model Settings #335

Closed
danielsclint opened this issue Aug 27, 2020 · 2 comments

Comments

@danielsclint
Copy link

In PR #325, the model configuration file for joint tour destination was pointed to use the same model specification as non_mandatory_tour_destination. For consistency sake, would it be better to keep each model self-contained in its own YAML?

trace_label = 'non_mandatory_tour_destination'
model_settings_file_name = 'non_mandatory_tour_destination.yaml'

@toliwaga
Copy link
Contributor

toliwaga commented Sep 4, 2020

Yes - and especially as there is such a file, but it is currently ignored (and missing a field)

The only thing is that sometimes (e.g. for mtctm1) it will be identical to non_mandatory_tour_destination.yaml

it would be nice to have a macro (like inherit_settings) that allows you to say something like:

include_settings: non_mandatory_tour_destination.yaml

@danielsclint
Copy link
Author

This was dealt with in PR #342.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants