Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing gives errors when not having the "main" site as source #305

Closed
kristoffeys opened this issue Feb 15, 2022 · 2 comments
Closed
Assignees
Labels
type: bug Something isn't working

Comments

@kristoffeys
Copy link

kristoffeys commented Feb 15, 2022

$element = Craft::$app->getElements()->getElementById($file->elementId, null, $order->siteId);

If we try to import a translation where the sourceSite is not our default site, the code above returns null.

By changing $order->siteId to $order->sourceSite, this seems to be fixed, is this a bug or am I missing something?

@sidedwards
Copy link
Collaborator

@kristoffeys, thank you for reporting this. While I wasn't able to reproduce the specific issue you described, the update makes sense and we'll investigate a fix.

@sidedwards sidedwards added this to the 📦 Release v2.2.0 milestone Feb 16, 2022
@sidedwards
Copy link
Collaborator

@kristoffeys, this was addressed in release v2.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants