Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow translation of Asset titles #170

Closed
robmcfadden opened this issue May 27, 2021 · 4 comments
Closed

Allow translation of Asset titles #170

robmcfadden opened this issue May 27, 2021 · 4 comments
Assignees
Labels
type: bug Something isn't working

Comments

@robmcfadden
Copy link
Contributor

Asset fields were recently added to the export: #8

This is great, but sometimes sites are using the title for the alt text instead of a field or for other reasons. If the title wasn't intentionally ignored for some reason, can we add that in?

https://github.com/robmcfadden/craft-translations/blob/asset-title-support/src/services/fieldtranslator/AssetsFieldTranslator.php#L40

Happy to make a PR for this. If this looks good, let me know which branch I should make the PR to. Thanks!

@ifrimere
Copy link
Contributor

@robmcfadden - thanks for the ticket and more thanks for the PR offer.

@sidedwards is going to look into this and will get back to you with any questions, requested edits to the PR proposal and guidance about the branch where it can be placed against.

Thanks.

@sidedwards
Copy link
Collaborator

@robmcfadden great catch! We have existing logic to handle updating Asset titles from XML files, but must have missed it for file generation. Your proposed fix looks good and I've confirmed that it works as expected. Please create a new branch off of master called bug/asset-title-fix, and I can merge it in with our next release v1.10.5.

Thanks!

@sidedwards sidedwards added the type: bug Something isn't working label Jun 2, 2021
@robmcfadden
Copy link
Contributor Author

@sidedwards Great, thanks! PR is going into master for now. Base branch can be changed to release/1.10.5 once available.

@sidedwards
Copy link
Collaborator

@robmcfadden merged #172 into release/1.10.5, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants