From b2b209d66db2cb9984ebc7f2bfb2583544f7ea0e Mon Sep 17 00:00:00 2001 From: Sumit Sharma Date: Fri, 21 Jan 2022 22:36:18 +0530 Subject: [PATCH] fix: refactor generate preview url flow --- src/services/repository/FileRepository.php | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/src/services/repository/FileRepository.php b/src/services/repository/FileRepository.php index f027da10..eabf694b 100644 --- a/src/services/repository/FileRepository.php +++ b/src/services/repository/FileRepository.php @@ -228,7 +228,7 @@ public function regeneratePreviewUrls($order, $previewUrls, $queue=null) { $service = new RegeneratePreviewUrls(); foreach ($order->files as $file) { - if (! ($file->hasDraft() || $file->isComplete())) continue; + if (! $file->isComplete()) continue; if ($queue) { $service->updateProgress($queue, $currentElement++ / $totalElements); @@ -239,18 +239,7 @@ public function regeneratePreviewUrls($order, $previewUrls, $queue=null) { $draft = Translations::$plugin->draftRepository->getDraftById($file->draftId, $file->targetSite); if ($draft) { - $element = Craft::$app->getElements()->getElementById($file->elementId, null, $file->sourceSite); $file->previewUrl = $previewUrls[$file->id] ?? $draft->url; - $file->source = Translations::$plugin->elementToFileConverter->convert( - $element, - Constants::FILE_FORMAT_XML, - [ - 'sourceSite' => $file->sourceSite, - 'targetSite' => $file->targetSite, - 'previewUrl' => $file->previewUrl, - 'orderId' => $file->orderId, - ] - ); } Translations::$plugin->fileRepository->saveFile($file);