Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: isolating extrinsic dryrun changes from block hook changes #295

Open
Tracked by #349
sander2 opened this issue May 10, 2023 · 3 comments
Open
Tracked by #349

Comments

@sander2
Copy link
Contributor

sander2 commented May 10, 2023

Currently, the output of the dry-run command is pretty noisy, since it includes changes caused be on_initialize and on_finalize hooks. It would be super helpful if there would be a way to only display the changes caused by the execution of the extrinsic itself. I'm not sure if this is feasible to implement. Maybe an approximation could be made by forking the chain and mining two blocks on different forks, and then comparing the result of both

@ermalkaleci
Copy link
Collaborator

try passing option --html --open

@sander2
Copy link
Contributor Author

sander2 commented May 10, 2023

Yea I was using that. It just has a lot of noise. For dev work that is not a problem. However, we're starting to use dry-run to demonstrate the effects of democracy proposals to other people, and then it helps a lot if the changes are as concise as possible, without irrelevant storage changes caused by block hooks

@xlc
Copy link
Member

xlc commented May 10, 2023

Yeah we can exclude results from hooks. Just need some refactoring.

@xlc xlc mentioned this issue Jul 27, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants