Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the + character in constructed docker tag #35

Closed
somaritane opened this issue May 31, 2021 · 0 comments · Fixed by #36
Closed

Replace the + character in constructed docker tag #35

somaritane opened this issue May 31, 2021 · 0 comments · Fixed by #36

Comments

@somaritane
Copy link

Replace the + character in constructed docker tag with -.
+ character is not defined in OCI spec opencontainers/distribution-spec#154
and therefore should not be necessarily supported by implementations.
At least with Docker version 20.10.6 it causes the image build failure:

docker build -t rancher/terraform-controller-executor:v0.0.0+d616b67-amd64 -f package/Dockerfile.executor 
invalid argument "rancher/terraform-controller-executor:v0.0.0+d616b67-amd64" for "-t, --tag" flag: invalid reference format
See 'docker build --help'.
@somaritane somaritane changed the title Replace the + character in constructed docker tag with -. Replace the + character in constructed docker tag with - May 31, 2021
@somaritane somaritane changed the title Replace the + character in constructed docker tag with - Replace the + character in constructed docker tag May 31, 2021
@somaritane somaritane mentioned this issue May 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix '+' character in docker image tag AbsaOSS/terraform-controller
1 participant
@somaritane