From 1222f510be7c6ca22487c7f6269c03b7343c5b13 Mon Sep 17 00:00:00 2001
From: Abraxas-365 <luisfmiranda8@gmail.com>
Date: Thu, 21 Mar 2024 10:11:33 -0500
Subject: [PATCH] refactor(llm): changing with_option of llm trait to
 add_options

changing with_option of llm trait to add_options for redability
---
 src/chain/llm_chain.rs     | 2 +-
 src/language_models/llm.rs | 5 ++++-
 src/llm/openai/mod.rs      | 2 +-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/chain/llm_chain.rs b/src/chain/llm_chain.rs
index 451c95d6..1bcc7487 100644
--- a/src/chain/llm_chain.rs
+++ b/src/chain/llm_chain.rs
@@ -57,7 +57,7 @@ impl LLMChainBuilder {
         let mut llm = self.llm.ok_or("LLM must be set")?;
         if let Some(options) = self.options {
             let llm_options = ChainCallOptions::to_llm_options(options);
-            llm.with_options(llm_options);
+            llm.add_options(llm_options);
         }
 
         let chain = LLMChain {
diff --git a/src/language_models/llm.rs b/src/language_models/llm.rs
index f5057436..319bef9a 100644
--- a/src/language_models/llm.rs
+++ b/src/language_models/llm.rs
@@ -21,7 +21,10 @@ pub trait LLM: Sync + Send {
         log::warn!("stream not implemented for this model");
         unimplemented!()
     }
-    fn with_options(&mut self, _options: CallOptions) {
+
+    /// This is usefull when you want to create a chain and override
+    /// LLM options
+    fn add_options(&mut self, _options: CallOptions) {
         // No action taken
     }
     //This is usefull when using non chat models
diff --git a/src/llm/openai/mod.rs b/src/llm/openai/mod.rs
index 151515b3..a0633826 100644
--- a/src/llm/openai/mod.rs
+++ b/src/llm/openai/mod.rs
@@ -175,7 +175,7 @@ impl<C: Config + Send + Sync> LLM for OpenAI<C> {
         Ok(Box::pin(new_stream))
     }
 
-    fn with_options(&mut self, options: CallOptions) {
+    fn add_options(&mut self, options: CallOptions) {
         self.options = options;
     }
 }