-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamic iframe url #73
Comments
Thanks for the contribution, @KutnerUri! I see your predicament and why you would want this feature. I want to make sure the security implications of not using For example, if, inside your https://symphony.bit.dev/api/resolve/teambit.organization page, a nefarious attacker could make a link appear that others could click on (for example, if you failed to inadequately escape HTML in a message board comment), and that link navigates an unsuspecting user's iframe to a nefarious page, then the nefarious page could communicate with your parent window and start receiving communication. Does that make sense? Would you be willing to accept that risk? |
Considering your comments that followed on the pull request, I think you're willing to accept the risk in your case. Thanks for your contribution, @KutnerUri! Released as v6.2.0. |
I'm using an iframe that includes redirects as part of it's setup, and I'm getting this error:
The setup goes something like this:
I wanted to disable the childOrigin check, but it does not seem to be possible. Leaving it as
""
orundefined
defaults to the iframe'ssrc
, and"*"
doesn't work.I don't have a way to know the final url of the iframe. Is there another property I can use? (like
name="..."
, ortitle="..."
)The text was updated successfully, but these errors were encountered: