Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: face_restoration_model and realesrgan_enabled_models are ignore by localization #12232

Closed
1 task done
daxijiu opened this issue Aug 1, 2023 · 1 comment
Closed
1 task done
Labels
bug-report Report of a bug, yet to be confirmed

Comments

@daxijiu
Copy link
Contributor

daxijiu commented Aug 1, 2023

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What happened?

in setting "Face restoration model" and "Select which Real-ESRGAN models" to show in the web UI.
and in extras "upscaler 1 & 2" are ignore by localization
such as
image
I noticed in the javascript/localization.js

var ignore_ids_for_localization = {
    setting_sd_hypernetwork: 'OPTION',
    setting_sd_model_checkpoint: 'OPTION',
    modelmerger_primary_model_name: 'OPTION',
    modelmerger_secondary_model_name: 'OPTION',
    modelmerger_tertiary_model_name: 'OPTION',
    train_embedding: 'OPTION',
    train_hypernetwork: 'OPTION',
    txt2img_styles: 'OPTION',
    img2img_styles: 'OPTION',
    setting_random_artist_categories: 'SPAN',
    setting_face_restoration_model: 'SPAN',
    setting_realesrgan_enabled_models: 'SPAN',
    extras_upscaler_1: 'SPAN',
    extras_upscaler_2: 'SPAN',
};

they are set to be ignore, why?
I tried changing it to OPTION and it seems to be working fine?

Steps to reproduce the problem

Use any localization plugin to view the above location.

What should have happened?

Perhaps these locations should be localizable.

Version or Commit where the problem happens

Version: v1.5.1

What Python version are you running on ?

Python 3.10.x

What platforms do you use to access the UI ?

Windows

What device are you running WebUI on?

Nvidia GPUs (RTX 20 above)

Cross attention optimization

xformers

What browsers do you use to access the UI ?

Microsoft Edge

Command Line Arguments

No

List of extensions

stable-diffusion-webui-inception-localization-zh_CN | https://github.com/daxijiu/stable-diffusion-webui-inception-localization-zh_CN

Console logs

no need

Additional information

No response

@daxijiu daxijiu added the bug-report Report of a bug, yet to be confirmed label Aug 1, 2023
@daxijiu daxijiu closed this as completed Aug 6, 2023
@daxijiu
Copy link
Contributor Author

daxijiu commented Aug 6, 2023

fixed by #12307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Report of a bug, yet to be confirmed
Projects
None yet
Development

No branches or pull requests

1 participant