Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PcsBuilder fails to add child list of leaf nodes #116

Closed
slarse opened this issue May 9, 2020 · 0 comments
Closed

PcsBuilder fails to add child list of leaf nodes #116

slarse opened this issue May 9, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@slarse
Copy link
Collaborator

slarse commented May 9, 2020

This is a serious bug. The PcsBuilder fails to add the empty child lists for leaf nodes. That is to say, a leaf node v should have PCS(v, START, END), but they don't get that. A consequence is that deletions that remove the entire child list aren't detected. For example, changing return 1; to return; goes unnoticed as the return statement's child list is entirely removed, but the empty child list is not represented in the PCS set.

This also means that the pseudocode in the thesis is incorrect. Oopsie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant