Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable the sha1 integrity removal (npm package manager) #9

Closed
asos-danielc opened this issue Nov 27, 2024 · 0 comments · Fixed by #10
Closed

Ability to disable the sha1 integrity removal (npm package manager) #9

asos-danielc opened this issue Nov 27, 2024 · 0 comments · Fixed by #10

Comments

@asos-danielc
Copy link
Contributor

Issue

Some private repositories, such as Azure Artifacts, do not support integrity sha's such as shar512 (default for NPM) but instead only use sha1. In turn, when snyker removes these properties, the subsequent npm install is not reinstated the sha1

Details

Using a repository that uses Azure Artifacts, run npx @asos/snyker --lockfile package-lock.json, you will see that all integrity properties get removed from the package-lock.json and not re-added.

The suggestion here is to add a flag, e.g. --preserve-integrity which in the instance of sha1 does not remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@asos-danielc and others