Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submodule and parent completion should try some filesystem resolution #68

Open
mickaelistria opened this issue Mar 9, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@mickaelistria
Copy link

Currently, it looks like submodule and parent completion can only repeat what's already set in the pom. However, those should try to look at local filesystem to provide completion.

@AObuchow
Copy link
Owner

AObuchow commented Mar 9, 2020

Agreed, I believe this is what m2e is already currently doing and we should replicate the existing behavior.

@AObuchow AObuchow added the enhancement New feature or request label Mar 9, 2020
@AObuchow
Copy link
Owner

AObuchow commented Mar 9, 2020

Should the strategy for this completion improvement be something like:

  • Look above/below in the filesystem hierarchy (above for parent, below for submodule)
  • If a pom.xml is encountered in the filesystem search, parse it (using MavenXpp3Reader or MavenProjectBuilder) to get GAV and add it to the completion

This opens a question for parent completion - when should we stop searching the filesystem? At the user's home directory (might not work well on Windows)? Should we have a depth constant which limits the search depth?

@mickaelistria
Copy link
Author

For the parent, I think we should stick to only pom in parent the parent folder if there is any.
in the relative paths, we can complete any string with the filesystem content (ie, complete target/output/ with the files and folders in this path).

@mickaelistria
Copy link
Author

Moved as eclipse-lemminx/lemminx-maven#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants