Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of syx_snapshot_dirty_list_add_hostaddr in cputlb.c #105

Open
enisrat opened this issue Mar 7, 2025 · 0 comments
Open

Use of syx_snapshot_dirty_list_add_hostaddr in cputlb.c #105

enisrat opened this issue Mar 7, 2025 · 0 comments

Comments

@enisrat
Copy link

enisrat commented Mar 7, 2025

I noticed that this access type check in cputlb.c has been commented out:

// TODO: Does not work?
// if (type == MMU_DATA_STORE) {
syx_snapshot_dirty_list_add_hostaddr(l->page[0].haddr);
// }

I don't see why this check would not work?

Also, pages with flags like TLB_MMIO and TLB_DISCARD_WRITE would not need to be considered for snapshot. Would it not make sense to check those as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant