Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Requirement: calendar fixes #8

Open
truth-quark opened this issue Jun 17, 2024 · 3 comments · May be fixed by #190
Open

Feature Requirement: calendar fixes #8

truth-quark opened this issue Jun 17, 2024 · 3 comments · May be fixed by #190
Labels
question Further information is requested

Comments

@truth-quark
Copy link
Collaborator

TODO: what is the requirement for calendar fixes?
TODO: add unit tests

Are these the relevant code sections?

@truth-quark truth-quark added the question Further information is requested label Jun 17, 2024
@MartinDix
Copy link
Contributor

Control runs often use nominal dates (or "model years"), starting from year 1. ESM1.5 uses a proleptic Gregorian calendar. The UM and iris only distinguish between 360 day and standard, so the calendar attribute isn't set correctly. This can causes date offsets with some post-processing software that's strict about the proleptic Gregorian vs standard=Julian/Gregorian distinction.

import iris
pr = iris.load_cube('/g/data/tm70/esm15_testing/sample_output/aiihca.paa1jan', 'rainfall_flux')
print(pr.coord('time'))

DimCoord :  time / (hours since 1970-01-01 00:00:00, standard calendar)
    points: [0101-01-16 12:00:00]
    bounds: [[0101-01-01 00:00:00, 0101-02-01 00:00:00]]
    shape: (1,)  bounds(1, 2)
    dtype: float64
    standard_name: 'time'

@aidanheerdegen
Copy link
Member

Note that MOM5 also has calendar issues, in that it claims to be gregorian (but also says it doesn't support gregorian in the code comments), but the calendar logic is for proleptic gregorian

COSIMA/access-om2#117

We could/should fix MOM5.

@aidanheerdegen
Copy link
Member

This comment:

#118 (comment)

Suggests there are only 3 supported calendar types. If that is the case the code should explicitly NOT support other types, and return an error to users.

@atteggiani atteggiani linked a pull request Feb 12, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants