-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Requirement: calendar fixes #8
Comments
Control runs often use nominal dates (or "model years"), starting from year 1. ESM1.5 uses a proleptic Gregorian calendar. The UM and iris only distinguish between 360 day and standard, so the calendar attribute isn't set correctly. This can causes date offsets with some post-processing software that's strict about the proleptic Gregorian vs standard=Julian/Gregorian distinction.
|
Note that MOM5 also has calendar issues, in that it claims to be gregorian (but also says it doesn't support gregorian in the code comments), but the calendar logic is for proleptic gregorian We could/should fix MOM5. |
This comment: Suggests there are only 3 supported calendar types. If that is the case the code should explicitly NOT support other types, and return an error to users. |
TODO
: what is the requirement for calendar fixes?TODO
: add unit testsAre these the relevant code sections?
The text was updated successfully, but these errors were encountered: