-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using main branch of model-config-tests in configs #109
Comments
@dougiesquire & @aidanheerdegen Please voice your support or not. My thinking is:
|
Sounds good. But I think allowing users to override this incase the main option introduces breaking changes? This can be more flexible while still encouraging the use of the laatest version for dev branches. |
Just to confirm my understanding, we're talking about a tag here? Yeah, I think this only adds flexibility. I support! |
This might be significant change. i.e. the ci config is specified in the main branch of a config repo but changes are made to configurations of branches in a repository. If fixing (Assuming i've understood this all correctly)
I believe a released version deployed to PyPI (which should be functionally equivalent to a git tag due to CD) |
Seems unnecessary at this point, but yeah sounds like a good idea and allows for better development and testing of model config tests, so heck yeah! |
Thanks @anton-seaice for the suggestion of adding a
main
option formodel-config-tests-version
in the CI configuration fileconfig/ci.json
. This would allow the option to have the latest tests run for particular branches - e.g.dev
branches (see #99 for allowing regex fordev-*
branches inconfig/ci.json
).This will require logic when each time
model-config-tests
is installed, e.g.pip install model-config-tests==<version>
to instead install the main branch ofmodel-config-tests
from github -pip install git+https://github.com/ACCESS-NRI/model-config-tests.git@main
I think using a fixed version of
model-config-tests
should be the default or recommended in general, so to allow for any breaking changes inmodel-config-tests
updates.The text was updated successfully, but these errors were encountered: