-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATM & DROF xml config #22
Comments
I think |
I think it's quite a good safety feature to have |
I think ill take that as consensus :) Actions:
|
We used 1900 in OM2 so I think we might as well stick with that. The first 4 mo of RYF9091 is from 1991 anyway. So I think we also change the start year in nuopc.runconfig to 1900 |
FYI re. #28, JRA55-do v1.5.0 runs to 15Jul2020, and v1.5.0.1 extends this to the end of 2023 https://climate.mri-jma.go.jp/pub/ocean/JRA55-do/ so experiments with these forcings will want a later ending date. |
Sounds like a seperate change to add these years? Do you want to do this now too? |
There is code in the python scripts to handle RYF (e.g. https://github.com/COSIMA/MOM6-CICE6/blob/51d97ab5a5ceafbb75fd0e519ab89458654e1ef5/generate_xml_datm.py#L96) but the python scripts are not in the RYF branch. Is this intentional? Did we decide not to use the script for RYF, or should the script be in both branches? |
We should move the script (and others) into a separate repo(s). @micaeljtoliveira mentioned he has some "om3 tools" in a repo somewhere. Perhaps we should get this into the COSIMA org and consolidate there. |
I created #29 :) |
Following on from #20 , two changes are proposed:
taxmode
tolimit
(doco: here). This means that if the model date is set outside the range of provided forcing data, the date would be rejected. (Currently it is cycled around when outside the range). (https://escomp.github.io/CDEPS/versions/master/html/streams.html#definitions-of-each-keys-used-in-stream-definition-file)year_first
,year_last
andyear_align
to be 1990 to be consistent with the input file. As data cycles around in the current setting, this does not make any functional change, but may be easier to interpret for future users. (The model year is set in thenuopc.runconfig
, and we would leave it set to year 0 to be clear its not a real year).The text was updated successfully, but these errors were encountered: