Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATM & DROF xml config #22

Closed
anton-seaice opened this issue Dec 7, 2023 · 10 comments
Closed

DATM & DROF xml config #22

anton-seaice opened this issue Dec 7, 2023 · 10 comments
Labels
1deg_jra55do_iaf 1deg_jra55do_iaf configuration 1deg_jra55do_ryf 1deg_jra55do_ryf configuration data Related to data models
Milestone

Comments

@anton-seaice
Copy link
Contributor

Following on from #20 , two changes are proposed:

  • In IAF configurations, for datm and drof, set taxmode to limit (doco: here). This means that if the model date is set outside the range of provided forcing data, the date would be rejected. (Currently it is cycled around when outside the range). (https://escomp.github.io/CDEPS/versions/master/html/streams.html#definitions-of-each-keys-used-in-stream-definition-file)
  • In RYF configurations, set year_first, year_last and year_align to be 1990 to be consistent with the input file. As data cycles around in the current setting, this does not make any functional change, but may be easier to interpret for future users. (The model year is set in the nuopc.runconfig, and we would leave it set to year 0 to be clear its not a real year).
@dougiesquire
Copy link
Collaborator

In RYF configurations, set year_first, year_last and year_align to be 1990

I think year_first and year_last need to remain at 1900, as the time variable in the files has been reset to span 1900 even though the data is from 1990-1991. But we could change year_align to 1900 so they are all consistent.

@aekiss
Copy link
Contributor

aekiss commented Dec 22, 2023

I think it's quite a good safety feature to have taxmode=limit to avoid users inadvertently getting into leap-year tangles like these (which are much worse with a forcing cycle not divisible by 4).

@anton-seaice
Copy link
Contributor Author

anton-seaice commented Jan 7, 2024

I think ill take that as consensus :)

Actions:

  • generate_xml_datm.py could be edited to change the comments re: year_align
  • generate_xml_datm.py change taxmode to 'limit'
  • generate new datm.streams.xml for IAF with taxmode='limit'
  • change datm.streams.xml for RYF, to set year_align=1900
  • repeat for drof

@anton-seaice
Copy link
Contributor Author

anton-seaice commented Jan 10, 2024

From @aekiss on slack:

We used 1900 in OM2 so I think we might as well stick with that. The first 4 mo of RYF9091 is from 1991 anyway.
Don't use 0000, since this may cause problems if any components use a strict definition of the Gregorian calendar as applying only from 15 October 1582 onwards, with a Julian calendar prior to that. COSIMA/access-om2#117

So I think we also change the start year in nuopc.runconfig to 1900

@aekiss
Copy link
Contributor

aekiss commented Jan 10, 2024

FYI re. #28, JRA55-do v1.5.0 runs to 15Jul2020, and v1.5.0.1 extends this to the end of 2023 https://climate.mri-jma.go.jp/pub/ocean/JRA55-do/ so experiments with these forcings will want a later ending date.

@anton-seaice
Copy link
Contributor Author

FYI re. #28, JRA55-do v1.5.0 runs to 15Jul2020, and v1.5.0.1 extends this to the end of 2023 https://climate.mri-jma.go.jp/pub/ocean/JRA55-do/ so experiments with these forcings will want a later ending date.

Sounds like a seperate change to add these years? Do you want to do this now too?

@anton-seaice
Copy link
Contributor Author

There is code in the python scripts to handle RYF (e.g. https://github.com/COSIMA/MOM6-CICE6/blob/51d97ab5a5ceafbb75fd0e519ab89458654e1ef5/generate_xml_datm.py#L96) but the python scripts are not in the RYF branch. Is this intentional? Did we decide not to use the script for RYF, or should the script be in both branches?

@dougiesquire
Copy link
Collaborator

There is code in the python scripts to handle RYF (e.g. https://github.com/COSIMA/MOM6-CICE6/blob/51d97ab5a5ceafbb75fd0e519ab89458654e1ef5/generate_xml_datm.py#L96) but the python scripts are not in the RYF branch. Is this intentional? Did we decide not to use the script for RYF, or should the script be in both branches?

We should move the script (and others) into a separate repo(s). @micaeljtoliveira mentioned he has some "om3 tools" in a repo somewhere. Perhaps we should get this into the COSIMA org and consolidate there.

@anton-seaice
Copy link
Contributor Author

We should move the script (and others) into a separate repo(s). @micaeljtoliveira mentioned he has some "om3 tools" in a repo somewhere. Perhaps we should get this into the COSIMA org and consolidate there.

I created #29 :)

@anton-seaice
Copy link
Contributor Author

Closed by #26 and #28

@micaeljtoliveira micaeljtoliveira added data Related to data models 1deg_jra55do_ryf 1deg_jra55do_ryf configuration 1deg_jra55do_iaf 1deg_jra55do_iaf configuration labels Jan 25, 2024
@micaeljtoliveira micaeljtoliveira added this to the 0.3.x milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1deg_jra55do_iaf 1deg_jra55do_iaf configuration 1deg_jra55do_ryf 1deg_jra55do_ryf configuration data Related to data models
Projects
None yet
Development

No branches or pull requests

4 participants