-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch up 1 deg configs with dev-025deg_jra55do_ryf
#181
Conversation
Update MOM_parameter_docs
!test repro |
Update MOM_parameter_docs
dev-1deg_jra55do_ryf
: disable MOM tidal momentum forcingdev-1deg_jra55do_ryf
: catch up with 0.25 configuration parameters
dev-1deg_jra55do_ryf
: catch up with 0.25 configuration parametersdev-025deg_jra55do_ryf
❌ The Bitwise Reproducibility Check Failed ❌ When comparing:
Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/a706052774b76dffd0071b07c0029bc53889e994/testing/checksum |
!test repro |
❌ The Bitwise Reproducibility Check Failed ❌ When comparing:
Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/a706052774b76dffd0071b07c0029bc53889e994/testing/checksum |
Note the reproducibility tests reported in the commit above failed because MOM aborted due to velocity truncations |
!test repro |
❌ The Bitwise Reproducibility Check Failed ❌ When comparing:
Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/a706052774b76dffd0071b07c0029bc53889e994/testing/checksum |
!test repro |
❌ The Bitwise Reproducibility Check Failed ❌ When comparing:
Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/a706052774b76dffd0071b07c0029bc53889e994/testing/checksum |
!test repro |
❌ The Bitwise Reproducibility Check Failed ❌ When comparing:
Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/a706052774b76dffd0071b07c0029bc53889e994/testing/checksum |
!test repro |
❌ The Bitwise Reproducibility Check Failed ❌ When comparing:
Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/a706052774b76dffd0071b07c0029bc53889e994/testing/checksum |
This reverts commit 4ff72ff.
Update MOM_parameter_docs
Update MOM_parameter_docs
Update MOM_parameter_docs
03dcd07
to
1d04cfc
Compare
@minghangli-uni, would you be able to take a look at this? Once you're happy with it, I'll update the checksums |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dougiesquire. I was able to run it successfully for a month. Just one question: while DIABATIC_FIRST
is agreed to be False, another issue is for DT and DT_THERM. I haven’t investigated this for the 1deg config yet, but I believe that the coupling timestep and cice therm timestep should at least match the MOM DT. This ensures that both components exchange fluxes at the same time, regardless of the final choice for dt_therm. This is what we do for the 0.25deg at the moment. So DT=DT_CPL=3600s? 1800s would be a bit low for the 1deg config.
Thanks @minghangli-uni. I'm not sure I understand all of your point sorry. The coupling timestep in this configuration is 3600s and both MOM and CICE exchange fluxes at that timestep, right? With I agree with you that the MOM dynamic timestep should probably be increased. But I think this probably requires some basic testing and should probably be done in a subsequent PR. @anton-seaice already opened an issue about this last week - see COSIMA/access-om3#268 |
My thinking is if dt is half of dt_cpl, would this delay feedback between ocean and cice? E.g., fluxes remain constant for two ocean baroclinic steps before being updated. |
I tried running with
and then MOM aborted due to velocity truncations. |
@minghangli-uni can we address this in a subsequent PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure lets finish this first.
!test repro commit |
❌ The Bitwise Reproducibility Check Failed ❌ When comparing:
🔧 The checksums will be committed to this PR, as they differ. Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/a706052774b76dffd0071b07c0029bc53889e994/testing/checksum |
2aad3d9
to
834378a
Compare
Automatic cherry-pick failed. Could not find commit(s) |
Duh! |
Automatic Git cherry-picking of commit(s) b7947cf d39270f 2d0a6cd 903774e 8a2fcab f711d80 d0278aa into dev-1deg_jra55do_iaf failed. This usually happens when cherry-picking results in a conflic or an empty commit. To manually cherry-pick the commits and open a pull request, please follow these instructions:
git checkout dev-1deg_jra55do_iaf
git pull
git checkout -b cherry_pick_from_pr181_into_dev-1deg_jra55do_iaf
git cherry-pick b7947cf1123d784c942547300d6fc6c8a4674631 d39270f261178d993dacbc125cf39dfaf0822cf8 2d0a6cdcdf06d885c623c384d109bbce713f664c 903774e71af678272ed8173bae5d8eb1b41a1b60 8a2fcab4c0d5e6a9a8dfabb5dd698af2061d1c7c f711d80fd8109aa85d83d01e228a526e700e8b60 d0278aa85adfe6f338e677e60cf20b06526c1a70
git push --set-upstream origin cherry_pick_from_pr181_into_dev-1deg_jra55do_iaf
|
This PR implements a few changes that were made to the
dev-025deg_jra55do_ryf
config but were not included in the 1 deg configs:DIABATIC_FIRST = False
(default). See UseDIABATIC_FIRST = False
COSIMA/access-om3#137.RESTART_CONTROL = 1
(default). With theCESMCOUPLED
cpp we don't actually use this parameter.MINIMUM_DEPTH = 0.0
(default). See https://forum.access-hive.org.au/t/namelist-configuration-discussion-meeting/1917/9?u=dougiesquire.BAD_VAL_*
values. This runs successfully for 1 year.HORIZ_VARYING_BACKGROUND = False
;KD = 0.0
(default). See 1deg_jra55do_ryf: Address MOM warnings COSIMA/access-om3#199