Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failing because of missing Shoop dependency. #5

Closed
Ambient-Impact opened this issue Apr 21, 2021 · 3 comments
Closed

Test failing because of missing Shoop dependency. #5

Ambient-Impact opened this issue Apr 21, 2021 · 3 comments

Comments

@Ambient-Impact
Copy link
Contributor

Describe the bug
composer install and then phpunit fails due to Error: Class 'Eightfold\Shoop\Shoop' not found 😓

To Reproduce
See above

Expected behavior
Test should not fail due to missing dependency.


I see that this was removed from the non-dev require in 88bd000, but still used in the tests. If I composer require "8fold/php-shoop:~0.5" --dev, I then get Error: Call to undefined method Eightfold\Shoop\Shoop::string(). 😱

@joshbruce
Copy link
Member

Hello! Thanks for letting me know.

I've added this to my more general list of tasks.

Given the prioritization at the moment, it might take a moment. In the meantime

I've labeled it as annoying as it doesn't affect package operation (outside of CI/CD), which means it's higher priority than new features and whatnot in that longer list.

If you would like (or need) it earlier to be comfortable using the package, let me know or please feel free to submit a PR.

Also, thank you for letting us know we're not the only ones using this package - always enjoy meeting a fellow user.

@joshbruce
Copy link
Member

joshbruce commented Apr 21, 2021

Spoke too soon. Higher priority given after realizing I couldn't install it locally as it has not been updated to accept PHP 8 environments.

Thanks again!

@Ambient-Impact
Copy link
Contributor Author

Glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants