Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gridMenu): GridMenu with multiple grids & event leak #244

Merged
merged 1 commit into from
May 18, 2018

Conversation

ghiscoding
Copy link
Collaborator

  • GridMenu was not working correctly with multiple grids
  • GridMenu was not showing correctly in a Modal Window because it's z-index was too low
  • Also found event leak, GridMenu should be destroyed on grid destroyed

Tested

  • Tested with 2 grids in the same page
    • Commands clicked on 1st grid Grid Menu should not affect 2nd grid
  • Destroying 2nd grid should destroy it's GridMenu as well & it's events attached without affecting the GridMenu of 1st grid
    • After 2nd grid is destroyed, we test that 1st GridMenu still work as expected

- GridMenu was not working correctly with multiple grids
- Also found event leak, GridMenu should be destroyed on grid destroyed
@6pac 6pac merged commit 16f9b1e into master May 18, 2018
@ghiscoding ghiscoding deleted the fix/grid-menu-with-multiple-grids branch May 18, 2018 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants