Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read option parsing is not good #3639

Closed
vagetablechicken opened this issue Nov 29, 2023 · 2 comments · Fixed by #3666
Closed

read option parsing is not good #3639

vagetablechicken opened this issue Nov 29, 2023 · 2 comments · Fixed by #3666
Assignees
@vagetablechicken
Labels
storage-engine openmldb storage engine. nameserver & tablet

Comments

@vagetablechicken
Copy link
Collaborator

OpenMLDB/src/sdk/sql_cluster_router.cc

Line 2817 in 71cf61e

openmldb::sdk::ReadFileOptionsParser options_parser;

Load data from hive or select out to, don't need to set format='hive', but if user set it, it'll be aborted by here. Should fix it.
@aceforeverd aceforeverd added the storage-engine openmldb storage engine. nameserver & tablet label Dec 4, 2023
@vagetablechicken
Copy link
Collaborator Author

refactor it in this week

@vagetablechicken vagetablechicken mentioned this issue Dec 7, 2023
Merged
@vagetablechicken
Copy link
Collaborator Author

vagetablechicken commented Jan 17, 2024 •
edited
Loading

load data option 'sql' will fail in v0.8.4, online or offline, Error: [2000] this option sql is not currently supported. After this pr, it'll be fixed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vagetablechicken vagetablechicken

Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: local load/write validate and refactor vagetablechicken/fedb
2 participants
@aceforeverd @vagetablechicken