Chore/migrate GitHub actions tox GitHub fixes #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-m-mclaughlin
changed the title
c0state
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
🙏🏼 - the result looks correct now. But I wonder why it didn't run the -s3 or even -base envs even without this.
edit: so tox-gh-actions takes over running things per https://github.com/ymyzk/tox-gh-actions/blob/master/ARCHITECTURE.md#overview (esp. if no " list of environments is explicitly given")
Or more generally, I wonder if we even need tox-gh-actions?
Will merge and maybe test further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@c0state This should fix the issue where the tests were skipping. There was some missing configuration in the usage of
tox-gh-actions. See: https://github.com/ymyzk/tox-gh-actions?tab=readme-ov-file#advanced-examplesThe successful action: https://github.com/4Catalyzer/flask-annex/actions/runs/10729836844. (it's not running again since this PR isn't against master)