Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to override response_headers in generate_url #16

Closed
cancan101 opened this issue Jun 28, 2016 · 2 comments
Closed

Ability to override response_headers in generate_url #16

cancan101 opened this issue Jun 28, 2016 · 2 comments

Comments

@cancan101
Copy link

cancan101 commented Jun 28, 2016

Add the ability to override response_headers in generate_url. This is important if you want to set something like Cache-Control.

@taion
Copy link
Contributor

taion commented Jun 28, 2016

I don't think that's the right API. For S3, we need to set the expiration time both on the S3 side and on the response side; those should derive from the same value.

@cancan101
Copy link
Author

Closing in favor of #19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants