Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare repository for next .github release and SBT build improvements #335

Merged
merged 26 commits into from
May 26, 2020

Conversation

alejandrohdezma
Copy link
Contributor

@alejandrohdezma alejandrohdezma commented May 25, 2020

What has been done in this PR?

Prepare project for next .github release

  • Add ci-publish command alias that will be used instead of ci-release for publishing artifacts.
  • Move docs templates to docs folder (as mdoc is expected).
  • Move microsite files to microsite folder.
  • Run github before ci-docs & ci-publish.
  • Remove ci-microsite (it gets inline in ci-docs).
  • Add actions.yml file that will be used by next .github release workflows to read pre/post conditions to run before/after ci-* commands.

Simplify SBT build

  • Re-order settings.
  • Remove unneeded settings.
  • Remove old sbt-org-policies markers.
  • Simplify modules by using the following features from SBT:
    • Auto-root project
    • project macro for setting project's name and baseDirectory (using the name of the lazy val)
    • Since we only have shared code in our cross-compiled modules use CrossType.Pure instead.
  • Add sbt-remove-test-from-pom to avoid publishing test dependencies to POM.
  • Add sbt-codecov to run tests with coverage and auto-upload to Codecov.

Update docs

  • Add a table of contents to README.md

Update versions

  • Update plugins to latest versions
  • Update Scala version to 2.13.2

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #335   +/-   ##
=======================================
  Coverage   68.56%   68.56%           
=======================================
  Files           8        8           
  Lines         299      299           
  Branches        3        4    +1     
=======================================
  Hits          205      205           
  Misses         94       94           
Impacted Files Coverage Δ
fetch-debug/src/main/scala/debug.scala 0.00% <ø> (ø)
fetch-debug/src/main/scala/document.scala 0.00% <ø> (ø)
fetch/src/main/scala/cache.scala 100.00% <ø> (ø)
fetch/src/main/scala/datasource.scala 100.00% <ø> (ø)
fetch/src/main/scala/execution.scala 100.00% <ø> (ø)
fetch/src/main/scala/fetch.scala 91.04% <ø> (ø)
fetch/src/main/scala/log.scala 66.66% <ø> (ø)
fetch/src/main/scala/syntax.scala 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 593d351...e485a5c. Read the comment docs.

Copy link
Contributor

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alejandrohdezma !

@alejandrohdezma alejandrohdezma merged commit 3bea4d5 into master May 26, 2020
@alejandrohdezma alejandrohdezma deleted the prepare-for-.github-release branch May 26, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants