-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign Implementation #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SASS cache files shouldn't be checked into the CVS
…nimation and top navbar scroll. Reorganizes head metas. Uses svg images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SASS cache file are still around, as they have been checked into VCS. Could we make sure they are not included in this PR?
Otherwise, as we are including them into the .gitignore
, we'll never get rid of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌝
* This is done to avoid Oracle JDKs to fail tests
@purrgrammer I've tried to fix the tests, since there was a change in Oracle JDK license that made it unavailable to certain machines in Travis. But after setting the jobs to run under Xenial, that hasn't fix them, could you have a look as you might have more context into it? OpenJDK is working fine, maybe Oracle JDK testing might be dropped altogether? Thanks! |
Yes, we've had issues with Oracle JDK in other builds too, we can just run the tests in OpenJDK 👍 |
* Drop tests support for Oracle JDK envs
… into paolo-201-implement-redesign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Outstanding work, LGTM 👏 |
It was just a misstep in the way of checking
…t-redesign Redesign Implementation
This PR updates the Fetch microsite implementing the new Fetch design.
For this we overwrite the jekyll site generated by sbt-microsites by adding a new home layout and overwriting the css classes that the documentation section uses.
It fixes #201
Do not merge since we need to wait for the Fetch Kotlin version implementation and the main site that will serve as a link to both sites #200. @47deg/marketing should schedulle these releases.