Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor interpreters + Change Fetch.traverse #123

Merged
merged 1 commit into from
Jun 1, 2017

Conversation

peterneyens
Copy link
Contributor

  • Create a interpreter package and split the three parts of the interpreter parts into three separate files.
  • Refactor processMany and processConcurrent in interpreter.CoreInterpreter
  • Fix a bug in the handling of FetchMany.
  • Customize the implementation of Fetch.traverse to reduce the stack needed to simplify/optimize the resulting Fetch.

With moving the interpreters and the reformating, it is a bit difficult to review ...

- Create a interpreter package and split the interpreter parts in three
  separate files.
- Fix a bug in the handling of `FetchMany`
- Customize the implementation of `Fetch.traverse` to reduce the stack
  needed to simplify/optimize the resulting `Fetch`
@codecov-io
Copy link

codecov-io commented Jun 1, 2017

Codecov Report

Merging #123 into master will increase coverage by 0.72%.
The diff coverage is 89.59%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #123      +/-   ##
========================================
+ Coverage   77.27%    78%   +0.72%     
========================================
  Files          11     14       +3     
  Lines         264    300      +36     
  Branches        2      2              
========================================
+ Hits          204    234      +30     
- Misses         60     66       +6
Impacted Files Coverage Δ
shared/src/main/scala/implicits.scala 100% <ø> (ø) ⬆️
shared/src/main/scala/datasource.scala 66.66% <ø> (ø) ⬆️
shared/src/main/scala/env.scala 50% <ø> (ø) ⬆️
monix/shared/src/main/scala/monix.scala 71.42% <ø> (ø) ⬆️
shared/src/main/scala/freeinspect.scala 61.53% <0%> (-11.19%) ⬇️
...rc/main/scala/interpreters/MaxBatchSizePhase.scala 100% <100%> (ø)
shared/src/main/scala/interpreters.scala 100% <100%> (+6.06%) ⬆️
shared/src/main/scala/cache.scala 84.61% <100%> (-7.06%) ⬇️
shared/src/main/scala/fetch.scala 82.92% <77.77%> (+2.92%) ⬆️
...rc/main/scala/interpreters/ParallelJoinPhase.scala 89.18% <89.18%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ffcef2...e65f999. Read the comment docs.

Copy link
Contributor

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@juanpedromoreno juanpedromoreno merged commit f5b2cfd into master Jun 1, 2017
@fedefernandez fedefernandez deleted the refactor-interpreters branch October 16, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants