Add "push_policy" command to the CLI #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
davidor
force-pushed
the
push-policy-schemas
branch
from
011713d to
e8fd1b1
Compare
mikz
reviewed
Jan 31, 2019
| local url = system_url(access_token, admin_portal_domain) | ||
|
|
||
| return http_client.post( | ||
| url, { name = name, version = version, schema = cjson.encode(manifest) } |
There was a problem hiding this comment.
You probably want back JSON, so you should send Accept: application/json and sending there JSON, so should send Content-Type: application/json.
There was a problem hiding this comment.
Or there should be http_ng.json.post that does it.
There was a problem hiding this comment.
You are right. Fixed 👍
|
@hallelujah In this PR, I assume that there's going to be a Can you please confirm that this looks OK to you whenever you have some time? Thanks! |
davidor
force-pushed
the
push-policy-schemas
branch
from
e8fd1b1 to
9caadaf
Compare
|
@davidor yes, for parameters we will have:
|
davidor
changed the title
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a command to push policy schemas to the 3scale admin portal.
I tagged it as WIP because we'll need confirmation from @hallelujah to make sure that the endpoints used and their parameters are correct.