Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeler output without specified output #362

Open
dingausmwald opened this issue Oct 13, 2021 · 6 comments
Open

Modeler output without specified output #362

dingausmwald opened this issue Oct 13, 2021 · 6 comments
Labels
bug An identified bug

Comments

@dingausmwald
Copy link

The "osm data from a raw query" algorithm in the modeler outputs layers even when they are not linked to an output. Is this normal? Tested with qgis 3.16 and 3.20

@dingausmwald dingausmwald added the bug An identified bug label Oct 13, 2021
@Gustry
Copy link
Member

Gustry commented Oct 13, 2021

Can you share a screenshot or can you explain what do you mean by "not linked to an output" ?

@dingausmwald
Copy link
Author

Hey. Ofc, thanks for the fast response.

For v.clean f.e. there is only a temporary layer output if you set names for the outputs (moreover, there is a extra output field for cleaned and errors). If not, the algorithm writes to a temporary file.
image

The osm raw query algorithm 1. has no further output fields for the outputs (file, points, lines, multilinestrings and multipolygons) but second, doesn't matter if you set a output name or not, there is always a temporary layer export.
image

@dingausmwald
Copy link
Author

Well, i removed

                context.addLayerToLoadOnCompletion(
                    layers[layer]['vector_layer'].id(),
                    layer_details
                )

from quickosm_process.py and this did the trick for me. I can still process the output in the modeler when referring to the algorithm output " "output lines" from algorithm "Download OSM data from raw query" " f.e.. No automatic temporary layer output anymore.

@Gustry
Copy link
Member

Gustry commented Oct 15, 2021

Ah yes indeed.
It seems logical. I will try to have a look soon.
Thanks for checking in the code ...

@kannes
Copy link
Contributor

kannes commented May 2, 2022

I just ran into this too. It would make using QuickOSM in modeller workflows much nicer in cases where intermediate data is not really needed in the end.

@pathmapper
Copy link

We are also running into this.

Additionally to the not needed/wanted output, depending on the features (if they hold a colour-key/value) there is also a somehow confusing error raised when running a model with the Download OSM data from a raw query-algorithm, because QuickOSM fails to style the unwanted output:

Sample model:
raw_query.zip

grafik

grafik

grafik

Raw query:

[out:xml] [timeout:2500];
{{geocodeArea:Kreis Viersen}} -> .area_0;
(
    nwr["amenity"="public_bookcase"](area.area_0);
   
);
(._;>;);
out body meta;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An identified bug
Projects
None yet
Development

No branches or pull requests

4 participants