-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
library release on cocoapods? #260
Comments
Hey @mattiaferrari02 👋 You can definitely add this Swift package to your react native project, just need to treat it as a dependency in Xcode. I will not be supporting cocoapods because the build system uses SPM directly which is why there are no If cocoapods is required, several secp256k1 pods exist even one that's a fork of this project. |
Ok thank you for letting me know about that, also, do you know this same lib but written in java? |
Noticed your reply. This package does support ElementsProject/secp256k1-zkp. You might want to fork this project, add the podspec from the cocoapod fork, then update the spec to point to the zkp source files instead. The two secp256k1 projects are nearly identical with mostly additional source files added to zkp but also added header paths to make it build for spm (which may or may not be needed for cocoapods).
Not familiar with java versions, GitHub does have several search results to look at though. |
yeah the only problem is that, your package works, i already tried adding a podspec to the elementsProject version (following what they did the fork of this project that you mentioned), but when i tried calling |
What does the zkp podspec look like? |
I forked the project and added the podspec https://github.com/mattiaferrari02/secp256k1-zkp/blob/master/secp256k1ZkpWrapper.podspec . To make it work i had to change some include paths aroud the project, this way at least compiles... |
Looks like there are a few issues in the spec. For example, using |
https://github.com/mattiaferrari02/secp256k1-zkp/blob/729e21836b2e250102afb4e2b3b5e38bac8023a9/secp256k1ZkpWrapper.podspec#L25 So do you think i should add "src/bench*.h" to the exclude_files? I simply tried porting the file existing podspec https://github.com/portto/secp256k1/blob/master/secp256k1Wrapper.podspec from the guy that you linked above, but as you can see he is using the bitcoin-core version and not the zkp one, there are some differences. |
This is reason for me suggesting SPM because this project supports zkp and you can reference the files included in |
Oh shit it works, I used your Really, thank you, now MAYBE I can proceed with my implementations! I still need to find the counterpart working in java (or kotlin), I looked to what you linked and they don't look so good... |
Do you plan to release the lib on cocoapods or to add a .podspec file in the repo.
I'm working on react native so I don't have access to swfit package manager, only to pods
The text was updated successfully, but these errors were encountered: