Fixes #135

Author: zachleat

src/ast.js

@@ -829,25 +829,6 @@ class AstSerializer {
 		return rawContent;
 	}
 
-	addImpliedWebCAttributes(node) {
-		// if(AstQuery.getTagName(node) === "template") {
-		if(AstQuery.isDeclarativeShadowDomNode(node)) {
-			AstModify.addAttribute(node, AstSerializer.attrs.RAW, "");
-		}
-
-		// webc:type="js" (WebC v0.9.0+) has implied webc:is="template" webc:nokeep
-		if(AstQuery.getAttributeValue(node, AstSerializer.attrs.TYPE) === AstSerializer.transformTypes.JS) {
-			// this check is perhaps unnecessary since KEEP has a higher precedence than NOKEEP
-			if(!AstQuery.hasAttribute(node, AstSerializer.attrs.KEEP)) {
-				AstModify.addAttribute(node, AstSerializer.attrs.NOKEEP, "");
-			}
-
-			if(!AstQuery.hasAttribute(node, AstSerializer.attrs.IS)) {
-				AstModify.addAttribute(node, AstSerializer.attrs.IS, "template");
-			}
-		}
-	}
-
 	addToInheritedBuckets(newBucketName, node, tagName, options) {
 		if(!newBucketName) {
 			return;
@@ -978,7 +959,7 @@ class AstSerializer {
 			return { html, currentNodeMetadata };
 		}
 
-		this.addImpliedWebCAttributes(node);
+		ComponentManager.addImpliedWebCAttributes(node);
 
 		let tagName = AstQuery.getTagName(node);
 		let content = "";

src/componentManager.js

@@ -2,6 +2,7 @@ import { createHash } from "crypto";
 
 import { WebC } from "../webc.js";
 import { AstQuery } from "./astQuery.js";
+import { AstModify } from "./astModify.js";
 import { AstSerializer } from "./ast.js";
 import { ModuleScript } from "./moduleScript.cjs";
 
@@ -133,6 +134,31 @@ class ComponentManager {
 			return this.getDigest(hash);
 		}
 	}
+	
+	/* Careful, this one mutates */
+	static addImpliedWebCAttributes(node) {
+		if(node._webcImpliedAttributesAdded) {
+			return;
+		}
+
+		node._webcImpliedAttributesAdded = true;
+
+		if(AstQuery.isDeclarativeShadowDomNode(node)) {
+			AstModify.addAttribute(node, AstSerializer.attrs.RAW, "");
+		}
+
+		// webc:type="js" (WebC v0.9.0+) has implied webc:is="template" webc:nokeep
+		if(AstQuery.getAttributeValue(node, AstSerializer.attrs.TYPE) === AstSerializer.transformTypes.JS) {
+			// this check is perhaps unnecessary since KEEP has a higher precedence than NOKEEP
+			if(!AstQuery.hasAttribute(node, AstSerializer.attrs.KEEP)) {
+				AstModify.addAttribute(node, AstSerializer.attrs.NOKEEP, "");
+			}
+
+			if(!AstQuery.hasAttribute(node, AstSerializer.attrs.IS)) {
+				AstModify.addAttribute(node, AstSerializer.attrs.IS, "template");
+			}
+		}
+	}
 
 	has(filePath) {
 		return filePath in this.components;
@@ -178,6 +204,12 @@ class ComponentManager {
 		let hasDeclarativeShadowDom = AstQuery.hasDeclarativeShadowDomChild(ast);
 
 		let topLevelNodes = AstQuery.getTopLevelNodes(ast);
+
+		// important for ignoreComponentParentTag, issue #135
+		for(let node of topLevelNodes) {
+			ComponentManager.addImpliedWebCAttributes(node);
+		}
+
 		let rootAttributeMode = this.getRootMode(topLevelNodes);
 		let ignoreRootTag = this.ignoreComponentParentTag(topLevelNodes, rootAttributeMode, hasDeclarativeShadowDom);
 

test/issue-135-test.js

@@ -0,0 +1,13 @@
+import test from "ava";
+import { WebC } from "../webc.js";
+
+test("script render function implied template should still be HTML-only #135", async t => {
+	let component = new WebC();
+
+	component.setInputPath("./test/stubs/issue-135/page.webc");
+	component.defineComponents("./test/stubs/issue-135/component.webc");
+
+	let { html } = await component.compile();
+
+	t.is(html.trim(), `<p>hello</p>`);
+});

test/stubs/issue-135/component.webc

@@ -0,0 +1,3 @@
+<script webc:type="js">
+"<p>hello</p>";
+</script>

test/stubs/issue-135/page.webc

@@ -0,0 +1 @@
+<component></component>