Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add new moduleEntry key to package.json to allow for manual addition of module scripts #386

Closed
fabiankaegy opened this issue Apr 9, 2024 · 2 comments · Fixed by #388

Comments

@fabiankaegy
Copy link
Member

In #372 we added support for JS modules to be loaded via block.json using the viewScriptModule & scriptModule keys. However since doing that I often ran into the need to actually add additional module scripts for extend some core functionality that isn't tied to a custom block we are developing.

So we need some way to also add some additional JS modules that are not added as entry points via a block.json file. Because of that I think it would be good to add a new moduleEntry key to the tenup toolkit config in package.json which would allow anyone to add additional module scriots.

@fabiankaegy
Copy link
Member Author

@nicholasio I would love to get your take on this before I go ahead and implement it 👍

@nicholasio
Copy link
Member

I think this makes sense - specially considering that the modules stuff per see isn't tied to the interactivity api and that the interactivity api itself is not technically tied to blocks.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants