Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

In tests, pre-deploy 0 accounts by default #150

Closed
ivpavici opened this issue Jul 5, 2022 · 0 comments · Fixed by #157
Closed

In tests, pre-deploy 0 accounts by default #150

ivpavici opened this issue Jul 5, 2022 · 0 comments · Fixed by #157
Assignees
@Nathan-SL
Labels
Type: feature New feature or request

Comments

@ivpavici
Copy link
Contributor

ivpavici commented Jul 5, 2022

This would reduce test log content and performance time.
However, it would increase line count and we would have to modify the tests where we need the accounts (we could only the number of accounts that we actually need).
@ivpavici ivpavici added the Type: feature New feature or request label Jul 5, 2022
@ivpavici ivpavici assigned Nathan-SL and unassigned Nathan-SL Jul 5, 2022
@Nathan-SL Nathan-SL mentioned this issue Jul 6, 2022
Merged
7 tasks
@ivpavici ivpavici moved this from 🏗 In progress to 👀 In review in starknet-devnet Jul 6, 2022
@ivpavici ivpavici moved this from 👀 In review to ✅ Done in starknet-devnet Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Nathan-SL Nathan-SL

Labels
Type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Zero pre deployed account as default 0xSpaceShard/starknet-devnet
2 participants
@ivpavici @Nathan-SL